From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF3BEB64DA for ; Fri, 21 Jul 2023 00:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjGUAkW (ORCPT ); Thu, 20 Jul 2023 20:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjGUAkU (ORCPT ); Thu, 20 Jul 2023 20:40:20 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACFE72729 for ; Thu, 20 Jul 2023 17:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689900018; x=1721436018; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CI0o0+Z4qXXHWD154B+rJnNKHysZxCwTxv7+kXT0cow=; b=RUZ3i03EpBCU4a1hRH5WLCKjhuqj1X25P0lQqRTJZyEFKcv5Ase2SWND XH3DffYyvDImgf4ZcHFTg5GcxMZlIvgW2pEGAR18baJNbUCAT5SvkZDmG bY7SaEd9zwl3IQvDja03mbM+SdKejgg+kFOQMtZyWDGpKmO3/Rt5tU/+n NErzW1PfmxVUf6XyTDIm1i4ZywvLWSpzGZvde+GZq/OrB+k3h0UmV1WRD 1Nmp22n3UuLhblY1ZHKFIN+eKVUkv+d83nnreqswwbkfauUiKZbCQMLas hWB4OqV86PLhba7GofGxLM5q6/HrJB7UHg85uKQYc7KkecV9oC6Mxzq2K A==; X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="433126716" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="433126716" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2023 17:40:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="868048756" Received: from lkp-server02.sh.intel.com (HELO 36946fcf73d7) ([10.239.97.151]) by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2023 17:40:16 -0700 Received: from kbuild by 36946fcf73d7 with local (Exim 4.96) (envelope-from ) id 1qMeBq-0006gL-2i; Fri, 21 Jul 2023 00:40:14 +0000 Date: Fri, 21 Jul 2023 08:38:40 +0800 From: kernel test robot To: Viresh Kumar , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Viresh Kumar , Vincent Guittot , Alex =?iso-8859-1?Q?Benn=E9e?= , stratos-dev@op-lists.linaro.org, Erik Schilling , Manos Pitsidianakis , Mathieu Poirier , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/2] xen: privcmd: Add support for irqfd Message-ID: <202307210852.ukq5f98v-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, kernel test robot noticed the following build errors: [auto build test ERROR on xen-tip/linux-next] [also build test ERROR on linus/master v6.5-rc2 next-20230720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Viresh-Kumar/xen-privcmd-Add-support-for-irqfd/20230720-173905 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next patch link: https://lore.kernel.org/r/a25d5f01fe9b4624aa12cab77abd001044ea02d5.1689845210.git.viresh.kumar%40linaro.org patch subject: [PATCH V2 2/2] xen: privcmd: Add support for irqfd config: arm64-randconfig-r026-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210852.ukq5f98v-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210852.ukq5f98v-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307210852.ukq5f98v-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/xen/privcmd.c:961:12: error: call to undeclared function 'eventfd_ctx_fileget'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 961 | eventfd = eventfd_ctx_fileget(f.file); | ^ drivers/xen/privcmd.c:961:12: note: did you mean 'eventfd_ctx_fdget'? include/linux/eventfd.h:56:35: note: 'eventfd_ctx_fdget' declared here 56 | static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) | ^ >> drivers/xen/privcmd.c:961:10: error: incompatible integer to pointer conversion assigning to 'struct eventfd_ctx *' from 'int' [-Wint-conversion] 961 | eventfd = eventfd_ctx_fileget(f.file); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. vim +/eventfd_ctx_fileget +961 drivers/xen/privcmd.c 936 937 static int privcmd_irqfd_assign(struct privcmd_irqfd *irqfd) 938 { 939 struct privcmd_kernel_irqfd *kirqfd, *tmp; 940 struct eventfd_ctx *eventfd; 941 __poll_t events; 942 struct fd f; 943 int ret; 944 945 kirqfd = kzalloc(sizeof(*kirqfd), GFP_KERNEL); 946 if (!kirqfd) 947 return -ENOMEM; 948 949 kirqfd->irq = irqfd->irq; 950 kirqfd->dom = irqfd->dom; 951 kirqfd->level = irqfd->level; 952 INIT_LIST_HEAD(&kirqfd->list); 953 INIT_WORK(&kirqfd->shutdown, irqfd_shutdown); 954 955 f = fdget(irqfd->fd); 956 if (!f.file) { 957 ret = -EBADF; 958 goto error_kfree; 959 } 960 > 961 eventfd = eventfd_ctx_fileget(f.file); 962 if (IS_ERR(eventfd)) { 963 ret = PTR_ERR(eventfd); 964 goto error_fd_put; 965 } 966 967 kirqfd->eventfd = eventfd; 968 969 /* 970 * Install our own custom wake-up handling so we are notified via a 971 * callback whenever someone signals the underlying eventfd. 972 */ 973 init_waitqueue_func_entry(&kirqfd->wait, irqfd_wakeup); 974 init_poll_funcptr(&kirqfd->pt, irqfd_poll_func); 975 976 mutex_lock(&irqfds_lock); 977 978 list_for_each_entry(tmp, &irqfds_list, list) { 979 if (kirqfd->eventfd == tmp->eventfd) { 980 ret = -EBUSY; 981 mutex_unlock(&irqfds_lock); 982 goto error_eventfd; 983 } 984 } 985 986 list_add_tail(&kirqfd->list, &irqfds_list); 987 mutex_unlock(&irqfds_lock); 988 989 /* 990 * Check if there was an event already pending on the eventfd before we 991 * registered, and trigger it as if we didn't miss it. 992 */ 993 events = vfs_poll(f.file, &kirqfd->pt); 994 if (events & EPOLLIN) 995 irqfd_inject(kirqfd); 996 997 /* 998 * Do not drop the file until the kirqfd is fully initialized, otherwise 999 * we might race against the EPOLLHUP. 1000 */ 1001 fdput(f); 1002 return 0; 1003 1004 error_eventfd: 1005 eventfd_ctx_put(eventfd); 1006 1007 error_fd_put: 1008 fdput(f); 1009 1010 error_kfree: 1011 kfree(kirqfd); 1012 return ret; 1013 } 1014 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki