From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: hsiangkao@linux.alibaba.com, chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, alexl@redhat.com
Subject: [PATCH v5 0/2] erofs: introduce xattr name bloom filter
Date: Fri, 21 Jul 2023 18:49:21 +0800 [thread overview]
Message-ID: <20230721104923.20236-1-jefflexu@linux.alibaba.com> (raw)
changes since v4:
- patch 2: polish commit message; declare erofs_inode.xattr_name_filter
as unsigned int instead of unsigned long; rename `bit` to `hashbit`;
use bitwise and instead of test_bit() to test the hashbit (Gao Xiang)
changes since v3:
- patch 1: add "Reviewed-by" tag (Gao Xiang)
- patch 2: make CONFIG_EROFS_FS_XATTR select CONFIG_XXHASH (Gao Xiang)
changes since v2:
- patch 1: polish the commit message; introduce xattr_filter_reserved in
on-disk superblock; remove EROFS_XATTR_FILTER_MASK (Gao Xiang)
changes since RFC:
- the number of hash functions is 1, and now it's implemented as:
xxh32(name, strlen(name), EROFS_XATTR_FILTER_SEED + index),
where the constant magic number EROFS_XATTR_FILTER_SEED [*] is used to
give a better spread for the mapping. (Alexander Larsson)
Refer to patch 1 for more details.
- fix the value of EROFS_FEATURE_COMPAT_XATTR_BLOOM; rename
EROFS_XATTR_BLOOM_* to EROFS_XATTR_FILTER_* (Gao Xiang)
- pass all tests in erofs-utils (MKFS_OPTIONS="--xattr-filter" make
check)
[*] https://lore.kernel.org/all/74a8a369-c3b0-b338-fa8f-fdd7c252efaf@linux.alibaba.com/
RFC: https://lore.kernel.org/all/20230621083209.116024-1-jefflexu@linux.alibaba.com/
v2: https://lore.kernel.org/all/20230705070427.92579-1-jefflexu@linux.alibaba.com/
v3: https://lore.kernel.org/all/20230712115123.33712-1-jefflexu@linux.alibaba.com/
v4: https://lore.kernel.org/all/20230714031034.53210-1-jefflexu@linux.alibaba.com/
Jingbo Xu (2):
erofs: update on-disk format for xattr name filter
erofs: boost negative xattr lookup with bloom filter
fs/erofs/Kconfig | 1 +
fs/erofs/erofs_fs.h | 10 ++++++++--
fs/erofs/internal.h | 3 +++
fs/erofs/super.c | 1 +
fs/erofs/xattr.c | 14 ++++++++++++++
5 files changed, 27 insertions(+), 2 deletions(-)
--
2.19.1.6.gb485710b
next reply other threads:[~2023-07-21 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:49 Jingbo Xu [this message]
2023-07-21 10:49 ` [PATCH v5 1/2] erofs: update on-disk format for xattr name filter Jingbo Xu
2023-07-21 10:49 ` [PATCH v5 2/2] erofs: boost negative xattr lookup with bloom filter Jingbo Xu
2023-07-22 7:05 ` Gao Xiang
2023-07-22 7:33 ` Jingbo Xu
2023-07-22 7:46 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721104923.20236-1-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox