public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>, <tiwai@suse.com>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v5 10/11] ALSA: hda: Fix missing header dependencies
Date: Fri, 21 Jul 2023 14:21:19 +0100	[thread overview]
Message-ID: <20230721132120.5523-11-rf@opensource.cirrus.com> (raw)
In-Reply-To: <20230721132120.5523-1-rf@opensource.cirrus.com>

Add #includes of dependencies into hda_auto_parser.h and hda_generic.h

hda_auto_parser.h uses definitions in hda_local.h.

hda_generic.h uses definitions in hda_local.h and hda_auto_parser.h.
It also references struct hda_jack_callback, but only as a pointer.
This has been forward-declared so hda_jack.h only needs to be
included in source that actually uses it.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_auto_parser.h | 2 ++
 sound/pci/hda/hda_generic.h     | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/sound/pci/hda/hda_auto_parser.h b/sound/pci/hda/hda_auto_parser.h
index df63d66af1ab..579b11beac71 100644
--- a/sound/pci/hda/hda_auto_parser.h
+++ b/sound/pci/hda/hda_auto_parser.h
@@ -8,6 +8,8 @@
 #ifndef __SOUND_HDA_AUTO_PARSER_H
 #define __SOUND_HDA_AUTO_PARSER_H
 
+#include "hda_local.h"
+
 /*
  * Helper for automatic pin configuration
  */
diff --git a/sound/pci/hda/hda_generic.h b/sound/pci/hda/hda_generic.h
index 34eba40cc6e6..a8eea8367629 100644
--- a/sound/pci/hda/hda_generic.h
+++ b/sound/pci/hda/hda_generic.h
@@ -9,6 +9,9 @@
 #define __SOUND_HDA_GENERIC_H
 
 #include <linux/leds.h>
+#include "hda_auto_parser.h"
+
+struct hda_jack_callback;
 
 /* table entry for multi-io paths */
 struct hda_multi_io {
-- 
2.30.2


  parent reply	other threads:[~2023-07-21 13:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 13:21 [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 01/11] ASoC: cs35l56: Move shared data into a common data structure Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 02/11] ASoC: cs35l56: Make cs35l56_system_reset() code more generic Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 03/11] ASoC: cs35l56: Convert utility functions to use common data structure Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 04/11] ASoC: cs35l56: Move utility functions to shared file Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 05/11] ASoC: cs35l56: Move runtime suspend/resume to shared library Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 06/11] ASoC: cs35l56: Move cs_dsp init into " Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 07/11] ASoC: cs35l56: Move part of cs35l56_init() to " Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 08/11] ASoC: cs35l56: Make common function for control port wait Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 09/11] ASoC: cs35l56: Make a common function to shutdown the DSP Richard Fitzgerald
2023-07-21 13:21 ` Richard Fitzgerald [this message]
2023-07-21 13:21 ` [PATCH v5 11/11] ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier Richard Fitzgerald
2023-07-21 14:50 ` [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems Takashi Iwai
2023-07-21 14:52   ` Mark Brown
2023-07-21 15:04     ` Takashi Iwai
2023-07-21 15:47       ` Takashi Iwai
2023-07-24 18:28 ` Mark Brown
2023-07-25  9:51   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721132120.5523-11-rf@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox