From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>, <tiwai@suse.com>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH v5 02/11] ASoC: cs35l56: Make cs35l56_system_reset() code more generic
Date: Fri, 21 Jul 2023 14:21:11 +0100 [thread overview]
Message-ID: <20230721132120.5523-3-rf@opensource.cirrus.com> (raw)
In-Reply-To: <20230721132120.5523-1-rf@opensource.cirrus.com>
From: Simon Trimmer <simont@opensource.cirrus.com>
The function can be more easily reused in HDA if the tracking of whether
a soft reset is being performed and whether the device is connected to a
SoundWire bus is moved out of the function.
Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Acked-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/cs35l56.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
index 4eb8e5b09bfd..7a83e388e869 100644
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -802,10 +802,8 @@ static const struct reg_sequence cs35l56_system_reset_seq[] = {
REG_SEQ0(CS35L56_DSP_VIRTUAL1_MBOX_1, CS35L56_MBOX_CMD_SYSTEM_RESET),
};
-static void cs35l56_system_reset(struct cs35l56_private *cs35l56)
+static void cs35l56_system_reset(struct cs35l56_private *cs35l56, bool is_soundwire)
{
- cs35l56->soft_resetting = true;
-
/*
* Must enter cache-only first so there can't be any more register
* accesses other than the controlled system reset sequence below.
@@ -816,7 +814,7 @@ static void cs35l56_system_reset(struct cs35l56_private *cs35l56)
ARRAY_SIZE(cs35l56_system_reset_seq));
/* On SoundWire the registers won't be accessible until it re-enumerates. */
- if (cs35l56->sdw_peripheral)
+ if (is_soundwire)
return;
usleep_range(CS35L56_CONTROL_PORT_READY_US, CS35L56_CONTROL_PORT_READY_US + 400);
@@ -883,7 +881,8 @@ static void cs35l56_patch(struct cs35l56_private *cs35l56)
init_completion(&cs35l56->init_completion);
- cs35l56_system_reset(cs35l56);
+ cs35l56->soft_resetting = true;
+ cs35l56_system_reset(cs35l56, !!cs35l56->sdw_peripheral);
if (cs35l56->sdw_peripheral) {
/*
@@ -1547,7 +1546,8 @@ int cs35l56_init(struct cs35l56_private *cs35l56)
if (!cs35l56->base.reset_gpio) {
dev_dbg(cs35l56->base.dev, "No reset gpio: using soft reset\n");
- cs35l56_system_reset(cs35l56);
+ cs35l56->soft_resetting = true;
+ cs35l56_system_reset(cs35l56, !!cs35l56->sdw_peripheral);
if (cs35l56->sdw_peripheral) {
/* Keep alive while we wait for re-enumeration */
pm_runtime_get_noresume(cs35l56->base.dev);
--
2.30.2
next prev parent reply other threads:[~2023-07-21 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:21 [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 01/11] ASoC: cs35l56: Move shared data into a common data structure Richard Fitzgerald
2023-07-21 13:21 ` Richard Fitzgerald [this message]
2023-07-21 13:21 ` [PATCH v5 03/11] ASoC: cs35l56: Convert utility functions to use " Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 04/11] ASoC: cs35l56: Move utility functions to shared file Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 05/11] ASoC: cs35l56: Move runtime suspend/resume to shared library Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 06/11] ASoC: cs35l56: Move cs_dsp init into " Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 07/11] ASoC: cs35l56: Move part of cs35l56_init() to " Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 08/11] ASoC: cs35l56: Make common function for control port wait Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 09/11] ASoC: cs35l56: Make a common function to shutdown the DSP Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 10/11] ALSA: hda: Fix missing header dependencies Richard Fitzgerald
2023-07-21 13:21 ` [PATCH v5 11/11] ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier Richard Fitzgerald
2023-07-21 14:50 ` [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems Takashi Iwai
2023-07-21 14:52 ` Mark Brown
2023-07-21 15:04 ` Takashi Iwai
2023-07-21 15:47 ` Takashi Iwai
2023-07-24 18:28 ` Mark Brown
2023-07-25 9:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721132120.5523-3-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox