Re: [PATCH v2 10/11] firmware: arm_scmi: Add the SCMI performance domain

Cristian Marussi
2023-07-19T14:52:23Z

On Thu, Jul 13, 2023 at 04:17:37PM +0200, Ulf Hansson wrote:
> To enable support for performance scaling (DVFS) for generic devices with
> the SCMI performance protocol, let's add an SCMI performance domain. This
> is being modelled as a genpd provider, with support for performance scaling
> through genpd's ->set_performance_state() callback.
>
> Note that, this adds the initial support that allows consumer drivers for
> attached devices, to vote for a new performance state via calling the
> dev_pm_genpd_set_performance_state(). However, this should be avoided as
> it's in most cases preferred to use the OPP library to vote for a new OPP
> instead. The support using the OPP library isn't part of this change, but
> needs to be implemented from subsequent changes.
>

Hi Ulf,

a couple of remarks down below.

> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> - Converted to use the new ->domain_info_get() callback.
>
> ---
> drivers/firmware/arm_scmi/Kconfig | 12 ++
> drivers/firmware/arm_scmi/Makefile | 1 +
> drivers/firmware/arm_scmi/scmi_perf_domain.c | 155 +++++++++++++++++++
> 3 files changed, 168 insertions(+)
> create mode 100644 drivers/firmware/arm_scmi/scmi_perf_domain.c

[snip]

> +static int scmi_perf_domain_probe(struct scmi_device *sdev)
> +{
> + struct device *dev = &sdev->dev;
> + const struct scmi_handle *handle = sdev->handle;
> + const struct scmi_perf_proto_ops *perf_ops;
> + struct scmi_protocol_handle *ph;
> + struct scmi_perf_domain *scmi_pd;
> + struct genpd_onecell_data *scmi_pd_data;
> + struct generic_pm_domain **domains;
> + int num_domains, i, ret = 0;
> + u32 perf_level;
> +
> + if (!handle)
> + return -ENODEV;
> +
> + /* The OF node must specify us as a power-domain provider. */
> + if (!of_find_property(dev->of_node, "#power-domain-cells", NULL))
> + return 0;
> +
> + perf_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PERF, &ph);
> + if (IS_ERR(perf_ops))
> + return PTR_ERR(perf_ops);
> +
> + num_domains = perf_ops->num_domains_get(ph);
> + if (num_domains < 0) {
> + dev_warn(dev, "Failed with %d when getting num perf domains\n",
> + num_domains);
> + return num_domains;
> + } else if (!num_domains) {
> + return 0;
> + }
> +
> + scmi_pd = devm_kcalloc(dev, num_domains, sizeof(*scmi_pd), GFP_KERNEL);
> + if (!scmi_pd)
> + return -ENOMEM;
> +
> + scmi_pd_data = devm_kzalloc(dev, sizeof(*scmi_pd_data), GFP_KERNEL);
> + if (!scmi_pd_data)
> + return -ENOMEM;
> +
> + domains = devm_kcalloc(dev, num_domains, sizeof(*domains), GFP_KERNEL);
> + if (!domains)
> + return -ENOMEM;
> +
> + for (i = 0; i < num_domains; i++, scmi_pd++) {
> + scmi_pd->info = perf_ops->domain_info_get(ph, i);

So here you are grabbing all the performance domains exposed by the
platform via PERF protocol and then a few lines down below you are
registering them with pm_genpd_init(), but the list of domains obtained
from the platform will contain NOT only devices but also CPUs possibly,
already managed by the SCMI CPUFreq driver.

In fact the SCMI CPUFreq driver, on his side, takes care to pick only
domains that are bound in the DT to a CPU (via scmi_cpu_domain_id DT
parsing) but here you are registering all domains with GenPD upfront.

Is it not possible that, once registered, GenPD can decide, at some point
in the future, to try act on some of these domains associated with a CPU ?
(like Clock framework does at the end of boot trying to disable unused
clocks...not familiar with internals of GenPD, though)

> + scmi_pd->domain_id = i;
> + scmi_pd->perf_ops = perf_ops;
> + scmi_pd->ph = ph;
> + scmi_pd->genpd.name = scmi_pd->info->name;
> + scmi_pd->genpd.flags = GENPD_FLAG_OPP_TABLE_FW;
> + scmi_pd->genpd.set_performance_state = scmi_pd_set_perf_state;
> +
> + ret = perf_ops->level_get(ph, i, &perf_level, false);
> + if (ret) {
> + dev_dbg(dev, "Failed to get perf level for %s",
> + scmi_pd->genpd.name);
> + perf_level = 0;
> + }
> +
> + /* Let the perf level indicate the power-state too. */
> + ret = pm_genpd_init(&scmi_pd->genpd, NULL, perf_level == 0);

In SCMI world PERF levels should have nothing to do with the Power
state of a domain: you have the POWER protocol for that, so you should
not assume that perf level 0 means OFF, but you can use the POWER protocol
operation .state_get() to lookup the power state. (and you can grab both
perf and power ops from the same driver)

The tricky part would be to match the PERF domain at hand with the
related POWER domain to query the state for, I suppose.

Indeed, recently, while looking at SCMI v3.2 PERF evolutions, I was
tempted to just start rejecting any level_set() or set_freq() request
for ZERO since they really can be abused to power off a domain. (if the
platform complies...)

Apologize if I missed something about how GenPD behaviour...

Thanks,
Cristian