From: Herve Codina <herve.codina@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] minmax: Fix header inclusions
Date: Fri, 21 Jul 2023 16:10:33 +0200 [thread overview]
Message-ID: <20230721161033.55bc133c@bootlin.com> (raw)
In-Reply-To: <20230721133932.12679-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Fri, 21 Jul 2023 16:39:32 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> BUILD_BUG_ON*() are defined in build_bug.h.
> It also provides __UNIQUE_ID() that is defined
> in the compiler.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/minmax.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/minmax.h b/include/linux/minmax.h
> index 798c6963909f..049480235e53 100644
> --- a/include/linux/minmax.h
> +++ b/include/linux/minmax.h
> @@ -2,6 +2,7 @@
> #ifndef _LINUX_MINMAX_H
> #define _LINUX_MINMAX_H
>
> +#include <linux/build_bug.h>
> #include <linux/const.h>
>
> /*
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2023-07-21 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:39 [PATCH v1 1/1] minmax: Fix header inclusions Andy Shevchenko
2023-07-21 14:10 ` Herve Codina [this message]
2023-07-24 14:29 ` Andy Shevchenko
2023-07-27 13:10 ` Andy Shevchenko
2023-07-21 15:52 ` kernel test robot
2023-07-21 16:01 ` Andy Shevchenko
2023-07-21 16:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721161033.55bc133c@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox