From: Aleksei Filippov <halip0503@gmail.com>
To: gregkh@linuxfoundation.org
Cc: halip0503@gmail.com, jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, shaggy@kernel.org,
syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com
Subject: [PATCH v4] jfs: validate max amount of blocks before allocation.
Date: Sun, 23 Jul 2023 16:58:22 +0300 [thread overview]
Message-ID: <20230723135822.5362-1-halip0503@gmail.com> (raw)
In-Reply-To: <2023072335-penniless-coleslaw-3aac@gregkh>
From: Alexei Filippov <halip0503@gmail.com>
The lack of checking bmp->db_max_freebud in extBalloc() can lead to
shift out of bounds, so this patch prevents undefined behavior, because
bmp->db_max_freebud == -1 only if there is no free space.
Signed-off-by: Aleksei Filippov <halip0503@gmail.com>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-and-tested-by: syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?id=01abadbd6ae6a08b1f1987aa61554c6b3ac19ff2
---
Changes:
Fix commit message.
fs/jfs/jfs_extent.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/jfs/jfs_extent.c b/fs/jfs/jfs_extent.c
index ae99a7e232ee..a82751e6c47f 100644
--- a/fs/jfs/jfs_extent.c
+++ b/fs/jfs/jfs_extent.c
@@ -311,6 +311,11 @@ extBalloc(struct inode *ip, s64 hint, s64 * nblocks, s64 * blkno)
* blocks in the map. in that case, we'll start off with the
* maximum free.
*/
+
+ /* give up if no space left */
+ if (bmp->db_maxfreebud == -1)
+ return -ENOSPC;
+
max = (s64) 1 << bmp->db_maxfreebud;
if (*nblocks >= max && *nblocks > nbperpage)
nb = nblks = (max > nbperpage) ? max : nbperpage;
--
2.25.1
next prev parent reply other threads:[~2023-07-23 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 14:24 [PATCH] jfs: validate max amount of blocks before allocation Aleksei Filippov
2023-07-22 15:16 ` Greg KH
2023-07-23 12:02 ` Aleksei Filippov
2023-07-23 12:06 ` Greg KH
2023-07-23 13:29 ` [PATCH v3] " Aleksei Filippov
2023-07-23 13:40 ` Greg KH
2023-07-23 13:58 ` Aleksei Filippov [this message]
2023-07-23 14:11 ` [PATCH v4] " Greg KH
2023-08-19 17:32 ` [PATCH v5] " Aleksei Filippov
2023-08-29 17:28 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230723135822.5362-1-halip0503@gmail.com \
--to=halip0503@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox