public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aleksei Filippov <halip0503@gmail.com>
Cc: jfs-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, shaggy@kernel.org,
	syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] jfs: validate max amount of blocks before allocation.
Date: Sun, 23 Jul 2023 16:11:18 +0200	[thread overview]
Message-ID: <2023072336-seventy-untangled-cbba@gregkh> (raw)
In-Reply-To: <20230723135822.5362-1-halip0503@gmail.com>

On Sun, Jul 23, 2023 at 04:58:22PM +0300, Aleksei Filippov wrote:
> From: Alexei Filippov <halip0503@gmail.com>
> 
> The lack of checking bmp->db_max_freebud in extBalloc() can lead to
> shift out of bounds, so this patch prevents undefined behavior, because
> bmp->db_max_freebud == -1 only if there is no free space.
> 
> Signed-off-by: Aleksei Filippov <halip0503@gmail.com>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-and-tested-by: syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?id=01abadbd6ae6a08b1f1987aa61554c6b3ac19ff2
> ---
> Changes:
> Fix commit message.
>  fs/jfs/jfs_extent.c | 5 +++++
>  1 file changed, 5 insertions(+)

{sigh}

Please, take some time, read the documentation for how to do this
correctly.  Wait a day, and then submit it again, properly.

Also, do you have a jfs system?  Isn't this filesystem obsolete?

thanks,

greg k-h

  reply	other threads:[~2023-07-23 14:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22 14:24 [PATCH] jfs: validate max amount of blocks before allocation Aleksei Filippov
2023-07-22 15:16 ` Greg KH
2023-07-23 12:02   ` Aleksei Filippov
2023-07-23 12:06     ` Greg KH
2023-07-23 13:29       ` [PATCH v3] " Aleksei Filippov
2023-07-23 13:40         ` Greg KH
2023-07-23 13:58           ` [PATCH v4] " Aleksei Filippov
2023-07-23 14:11             ` Greg KH [this message]
2023-08-19 17:32               ` [PATCH v5] " Aleksei Filippov
2023-08-29 17:28                 ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023072336-seventy-untangled-cbba@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=halip0503@gmail.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaggy@kernel.org \
    --cc=syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox