From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3988C001DF for ; Mon, 24 Jul 2023 01:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbjGXBUI (ORCPT ); Sun, 23 Jul 2023 21:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbjGXBUH (ORCPT ); Sun, 23 Jul 2023 21:20:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB7E1BB; Sun, 23 Jul 2023 18:19:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F61760F05; Mon, 24 Jul 2023 01:18:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E123EC433C7; Mon, 24 Jul 2023 01:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690161517; bh=Gm7xMPFN6RJVQ+Wp6OwKlm6mqZ19x2ksKi4VSKNYyFk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m8haTTgwnKbs/GeUkvRYMRYmlPVTzngCPso7ejazfr2JnadFzn0xRFZFv/i1TyAp1 en+X50i/+MMCgZyGp1JEnWwyGK5n2Jw5YMyw+7KLCW4nu1RNn0UfLLw31a8IFi+Dm1 tvqtiimp1HejkbgabEUvayUA0xHbEFY4QhxjZtpPMm4Os7Cg0TQMZZHpdi5mWNN5Cq NqDKAbHcS790z3MLVkTphlgTwlSxoaYiEsf6OnW0kCBuWUfUtlYvX4DWzsMMsbGeOw KT6EuP2iU/wvYpVXQOmf2KVsmuzRy3Rkq0U9Og3aAtTVhub865ez9UHmiNHsvvakvq Jxt1fnAidxapg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Moti Haimovski , Dani Liberman , Oded Gabbay , Sasha Levin , obitton@habana.ai, ttayar@habana.ai, kelbaz@habana.ai, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.4 32/58] accel/habanalabs: fix mem leak in capture user mappings Date: Sun, 23 Jul 2023 21:13:00 -0400 Message-Id: <20230724011338.2298062-32-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724011338.2298062-1-sashal@kernel.org> References: <20230724011338.2298062-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.5 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Moti Haimovski [ Upstream commit 314a7ffd7c196b27eedd50cb7553029e17789b55 ] This commit fixes a memory leak caused when clearing the user_mappings info when a new context is opened immediately after user_mapping is captured and a hard reset is performed. Signed-off-by: Moti Haimovski Reviewed-by: Dani Liberman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin --- drivers/accel/habanalabs/common/habanalabs_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/habanalabs/common/habanalabs_drv.c b/drivers/accel/habanalabs/common/habanalabs_drv.c index 1ec97da3dddb8..70fb2df9a93b8 100644 --- a/drivers/accel/habanalabs/common/habanalabs_drv.c +++ b/drivers/accel/habanalabs/common/habanalabs_drv.c @@ -13,6 +13,7 @@ #include #include +#include #define CREATE_TRACE_POINTS #include @@ -218,6 +219,7 @@ int hl_device_open(struct inode *inode, struct file *filp) hl_debugfs_add_file(hpriv); + vfree(hdev->captured_err_info.page_fault_info.user_mappings); memset(&hdev->captured_err_info, 0, sizeof(hdev->captured_err_info)); atomic_set(&hdev->captured_err_info.cs_timeout.write_enable, 1); hdev->captured_err_info.undef_opcode.write_enable = true; -- 2.39.2