From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97AF6C001B0 for ; Mon, 24 Jul 2023 01:28:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbjGXB2v (ORCPT ); Sun, 23 Jul 2023 21:28:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231551AbjGXB1w (ORCPT ); Sun, 23 Jul 2023 21:27:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3583410D1; Sun, 23 Jul 2023 18:25:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A73560EEE; Mon, 24 Jul 2023 01:24:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3600C433C8; Mon, 24 Jul 2023 01:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690161857; bh=ZGbe+PNKOide2xjOsnHqwygLaXz2EjI4SMhtA/0vl+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=REWIjKiLHR+eYSV7aVh0MAhbWGb0YOJlSPXmLmEH5mZU5wqIchKbuBLaK2xHyQN9M 2Cisl8K/GKCKftrBWE+Sf9Q++CllJQK/noHQgzT1TvCDBG9Ec06wfdtx52CyX0h79z jJ0Hys9s559asNF5hC0fbic0x6YOe9B0eL5uhtEDL4XsE5aVEBPvz5+cAllN6OvKTX QJMUYwE7jeUq1taonHeSAjZKcIxtKDDyubqRs8w2eW2s1lD/hEUYnkITG7LX95kvLO ixbYfM6/MRPjYt7LCbRdRzcFlUgg7DFeuEoxBBMmyNXfr+PKVCY6FvIO+l/X753Zpl 6DuqDL2hxp/lg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Immad Mir , Dave Kleikamp , Sasha Levin , shaggy@kernel.org, jfs-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.15 23/23] FS: JFS: Check for read-only mounted filesystem in txBegin Date: Sun, 23 Jul 2023 21:23:34 -0400 Message-Id: <20230724012334.2317140-23-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724012334.2317140-1-sashal@kernel.org> References: <20230724012334.2317140-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.121 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Immad Mir [ Upstream commit 95e2b352c03b0a86c5717ba1d24ea20969abcacc ] This patch adds a check for read-only mounted filesystem in txBegin before starting a transaction potentially saving from NULL pointer deref. Signed-off-by: Immad Mir Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_txnmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index 042bbe6d8ac2e..6c8680d3907af 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -354,6 +354,11 @@ tid_t txBegin(struct super_block *sb, int flag) jfs_info("txBegin: flag = 0x%x", flag); log = JFS_SBI(sb)->log; + if (!log) { + jfs_error(sb, "read-only filesystem\n"); + return 0; + } + TXN_LOCK(); INCREMENT(TxStat.txBegin); -- 2.39.2