From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] OPP: Reuse dev_pm_opp_get_freq_indexed()
Date: Mon, 24 Jul 2023 11:56:57 +0530 [thread overview]
Message-ID: <20230724062657.GL2370@thinkpad> (raw)
In-Reply-To: <5ddded46303f9d034ecb79f1fcc48abcc590f7db.1689932341.git.viresh.kumar@linaro.org>
On Fri, Jul 21, 2023 at 03:10:59PM +0530, Viresh Kumar wrote:
> Reuse dev_pm_opp_get_freq_indexed() from dev_pm_opp_get_freq().
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/opp/core.c | 21 ---------------------
> include/linux/pm_opp.h | 12 +++++-------
> 2 files changed, 5 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 95f49fbe431c..16a103e6695b 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -176,27 +176,6 @@ unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp)
> }
> EXPORT_SYMBOL_GPL(dev_pm_opp_get_power);
>
> -/**
> - * dev_pm_opp_get_freq() - Gets the frequency corresponding to an available opp
> - * @opp: opp for which frequency has to be returned for
> - *
> - * Return: frequency in hertz corresponding to the opp, else
> - * return 0
> - */
> -unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
> -{
> - if (IS_ERR_OR_NULL(opp)) {
> - pr_err("%s: Invalid parameters\n", __func__);
> - return 0;
> - }
> -
> - if (!assert_single_clk(opp->opp_table))
> - return 0;
> -
> - return opp->rates[0];
> -}
> -EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq);
> -
> /**
> * dev_pm_opp_get_freq_indexed() - Gets the frequency corresponding to an
> * available opp with specified index
> diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
> index 23e4e4eaaa42..91f87d7e807c 100644
> --- a/include/linux/pm_opp.h
> +++ b/include/linux/pm_opp.h
> @@ -103,8 +103,6 @@ int dev_pm_opp_get_supplies(struct dev_pm_opp *opp, struct dev_pm_opp_supply *su
>
> unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp);
>
> -unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp);
> -
> unsigned long dev_pm_opp_get_freq_indexed(struct dev_pm_opp *opp, u32 index);
>
> unsigned int dev_pm_opp_get_level(struct dev_pm_opp *opp);
> @@ -214,11 +212,6 @@ static inline unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp)
> return 0;
> }
>
> -static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
> -{
> - return 0;
> -}
> -
> static inline unsigned long dev_pm_opp_get_freq_indexed(struct dev_pm_opp *opp, u32 index)
> {
> return 0;
> @@ -669,4 +662,9 @@ static inline void dev_pm_opp_put_prop_name(int token)
> dev_pm_opp_clear_config(token);
> }
>
> +static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
> +{
> + return dev_pm_opp_get_freq_indexed(opp, 0);
> +}
> +
> #endif /* __LINUX_OPP_H__ */
> --
> 2.31.1.272.g89b43f80a514
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-07-24 6:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:40 [PATCH 0/6] OPP: Indexed searching based on frequency Viresh Kumar
2023-07-21 9:40 ` [PATCH 1/6] OPP: Rearrange entries in pm_opp.h Viresh Kumar
2023-07-21 9:40 ` [PATCH 2/6] OPP: Introduce dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Viresh Kumar
2023-07-21 9:40 ` [PATCH 3/6] OPP: Introduce dev_pm_opp_get_freq_indexed() API Viresh Kumar
2023-07-21 9:40 ` [PATCH 4/6] OPP: Add dev_pm_opp_find_freq_exact_indexed() Viresh Kumar
2023-07-24 6:24 ` Manivannan Sadhasivam
2023-07-24 7:31 ` Viresh Kumar
2023-07-21 9:40 ` [PATCH 5/6] OPP: Update _read_freq() to return the correct frequency Viresh Kumar
2023-07-24 6:25 ` Manivannan Sadhasivam
2023-07-21 9:40 ` [PATCH 6/6] OPP: Reuse dev_pm_opp_get_freq_indexed() Viresh Kumar
2023-07-24 6:26 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724062657.GL2370@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).