From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6664C001DE for ; Mon, 24 Jul 2023 13:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbjGXNJQ (ORCPT ); Mon, 24 Jul 2023 09:09:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjGXNJO (ORCPT ); Mon, 24 Jul 2023 09:09:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B406B7; Mon, 24 Jul 2023 06:09:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 083B661167; Mon, 24 Jul 2023 13:09:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65EBC433C8; Mon, 24 Jul 2023 13:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690204152; bh=bqj0qc6F2RAS2pFRIJnXo55WQzynV/DUzSrrH+mRIns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aKDJ2GjRqhzuMfS7jW1QgIj9P4r2MNDTDvv9Z4rN3mbSjgqhM1f4uWC0slCinrONS uEmyTLr42hFasmjBvC0ZaF31dpEJrv7Rj9zdY60HZ3v7vHNi9aKJzOtUajK4t2GUD3 upOSt4lxMvGv51WonaeNO4WN72l3NtMYJGKYFClaYG9zsQ3gX4MbI+tq30mjBUKkXt OzdjTZG6qgQRpy+ztSviOpA1KChG4sLIBPsow0xIos4GhtwI2VNkixP5PHO5aNGlQ7 TbvA4P8H+x9IX6k+6h9Xen6HcGX/40GYJ/BOGSu3WFTxZr4Bdnw9k246+LCdQyfZ2s Ig86OoAWnCZKA== Date: Mon, 24 Jul 2023 18:38:55 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Praveenkumar I , agross@kernel.org, andersson@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_varada@quicinc.com, quic_devipriy@quicinc.com Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574 Message-ID: <20230724130855.GO6291@thinkpad> References: <20230724124711.2346886-1-quic_ipkumar@quicinc.com> <20230724124711.2346886-2-quic_ipkumar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 02:53:37PM +0200, Konrad Dybcio wrote: > On 24.07.2023 14:47, Praveenkumar I wrote: > > Set 256 bytes as payload size for IPQ9574 via early fixup. This allows > > PCIe RC to use the max payload size when a capable link partner is > > connected. > > > > Signed-off-by: Praveenkumar I > > --- > [...] > > > > > +static void qcom_fixup_mps_256(struct pci_dev *dev) > > +{ > > + pcie_set_mps(dev, 256); > Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic > code take care of this. > Right, also this setting should not be PCI-PCI bridge specific but rather controller specific. - Mani > Konrad -- மணிவண்ணன் சதாசிவம்