From: Manivannan Sadhasivam <mani@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>,
agross@kernel.org, andersson@kernel.org, lpieralisi@kernel.org,
kw@linux.com, robh@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_varada@quicinc.com,
quic_devipriy@quicinc.com
Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574
Date: Mon, 24 Jul 2023 19:39:40 +0530 [thread overview]
Message-ID: <20230724140940.GP6291@thinkpad> (raw)
In-Reply-To: <20230724130855.GO6291@thinkpad>
On Mon, Jul 24, 2023 at 06:38:55PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Jul 24, 2023 at 02:53:37PM +0200, Konrad Dybcio wrote:
> > On 24.07.2023 14:47, Praveenkumar I wrote:
> > > Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
> > > PCIe RC to use the max payload size when a capable link partner is
> > > connected.
> > >
> > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> > > ---
> > [...]
> >
> > >
> > > +static void qcom_fixup_mps_256(struct pci_dev *dev)
> > > +{
> > > + pcie_set_mps(dev, 256);
> > Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
> > code take care of this.
> >
>
> Right, also this setting should not be PCI-PCI bridge specific but rather
> controller specific.
>
Wait, have you tested this patch with PCIe devices having MPS < 256 i.e.,
default 128?
Take a look at this discussion: https://lore.kernel.org/all/20230608093652.1409485-1-vidyas@nvidia.com/
- Mani
> - Mani
>
> > Konrad
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-07-24 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 12:47 [PATCH 0/1] Set may payload size for IPQ9574 Praveenkumar I
2023-07-24 12:47 ` [PATCH 1/1] PCI: qcom: Add early fixup to set the max " Praveenkumar I
2023-07-24 12:53 ` Konrad Dybcio
2023-07-24 13:08 ` Manivannan Sadhasivam
2023-07-24 14:09 ` Manivannan Sadhasivam [this message]
2023-07-25 4:46 ` Praveenkumar I
2023-07-25 6:06 ` Manivannan Sadhasivam
2023-07-26 7:28 ` Praveenkumar I
2023-07-26 9:22 ` Praveenkumar I
2023-07-26 10:49 ` Praveenkumar I
2023-07-24 13:51 ` Praveenkumar I
2023-07-24 12:50 ` [PATCH 0/1] Set may " Konrad Dybcio
2023-07-25 4:24 ` Praveenkumar I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724140940.GP6291@thinkpad \
--to=mani@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_devipriy@quicinc.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox