From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jagan Sridharan <badhri@google.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Min Guo <min.guo@mediatek.com>, Gene Chen <gene_chen@richtek.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector
Date: Mon, 24 Jul 2023 10:26:38 -0600 [thread overview]
Message-ID: <20230724162638.GA3784203-robh@kernel.org> (raw)
In-Reply-To: <20230723071105.40157-1-krzysztof.kozlowski@linaro.org>
On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
> The usb-connector.yaml schema allows any additional properties, thus its
> usage should finish with unevaluatedProperties: false.
Is it problematic if usb-connector.yaml is restricted?
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
> Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 1 +
> Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 1 +
> Documentation/devicetree/bindings/usb/mediatek,musb.yaml | 1 +
> Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 1 +
> Documentation/devicetree/bindings/usb/richtek,rt1719.yaml | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> index 276bf7554215..45e093978b82 100644
> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> @@ -25,6 +25,7 @@ properties:
> connector:
> type: object
> $ref: ../connector/usb-connector.yaml#
> + unevaluatedProperties: false
> description:
> Properties for usb c connector.
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..42b9d3a35c67 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -29,6 +29,7 @@ properties:
> connector:
> type: object
> $ref: ../connector/usb-connector.yaml#
> + unevaluatedProperties: false
> description:
> Properties for usb c connector.
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index a59d91243ac8..7eb880e4a270 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -144,6 +144,7 @@ properties:
>
> connector:
> $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> description:
> Connector for dual role switch, especially for "gpio-usb-b-connector"
> type: object
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> index a39d38db7714..924f74d45baa 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml
> @@ -66,6 +66,7 @@ properties:
> $ref: /schemas/connector/usb-connector.yaml#
> description: Connector for dual role switch
> type: object
> + unevaluatedProperties: false
>
> dependencies:
> usb-role-switch: [ connector ]
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> index 8da4d2ad1a91..980235e27a7f 100644
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> @@ -36,6 +36,7 @@ properties:
> connector:
> type: object
> $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> description:
> Properties for usb c connector.
>
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> index 4ced2f68e2a9..27978580b234 100644
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml
> @@ -34,6 +34,7 @@ properties:
> connector:
> type: object
> $ref: ../connector/usb-connector.yaml#
> + unevaluatedProperties: false
> description:
> Properties for usb c connector.
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-07-24 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 7:11 [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector Krzysztof Kozlowski
2023-07-24 16:26 ` Rob Herring [this message]
2023-07-24 17:05 ` Krzysztof Kozlowski
2023-07-24 21:02 ` Rob Herring
2023-07-25 10:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724162638.GA3784203-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=badhri@google.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox