Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector

Rob Herring
2023-07-24T21:02:43Z

On Mon, Jul 24, 2023 at 11:05 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 24/07/2023 18:26, Rob Herring wrote:
> > On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
> >> The usb-connector.yaml schema allows any additional properties, thus its
> >> usage should finish with unevaluatedProperties: false.
> >
> > Is it problematic if usb-connector.yaml is restricted?
>
> Yes, a bit.
> 1. Missing reg/unit-address:
> Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> I guess this could be easily solved.
>
> 2. phy-supply:
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> (and more of armada)
> This is a bit odd:
>
> phy@18300 {
> compatible = "marvell,comphy-a3700";
> comphy0: phy@0 {}
> comphy1: phy@1 {}
> comphy2: phy@2 {
> connector {
> compatible = "usb-a-connector";
> phy-supply = <&exp_usb3_vbus>;
> };
> };
>
> I would assume that phy-supply should be a property of the phy.

Indeed. We already have vbus-supply which this looks like it is. I'm
pretty sure I've seen Vbus in phy bindings too which I've pushed back
on as to whether Vbus really went to the phy or was there because the
phy driver just wants to control Vbus.

The marvell platforms aren't in great shape schema wise, so maybe
don't worry about it now.

Rob