Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector

Krzysztof Kozlowski
2023-07-24T17:05:47Z

On 24/07/2023 18:26, Rob Herring wrote:
> On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
>> The usb-connector.yaml schema allows any additional properties, thus its
>> usage should finish with unevaluatedProperties: false.
>
> Is it problematic if usb-connector.yaml is restricted?

Yes, a bit.
1. Missing reg/unit-address:
Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
I guess this could be easily solved.

2. phy-supply:
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
(and more of armada)
This is a bit odd:

phy@18300 {
compatible = "marvell,comphy-a3700";
comphy0: phy@0 {}
comphy1: phy@1 {}
comphy2: phy@2 {
connector {
compatible = "usb-a-connector";
phy-supply = <&exp_usb3_vbus>;
};
};

I would assume that phy-supply should be a property of the phy.

Best regards,
Krzysztof