From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Nitesh Shetty <nj.shetty@samsung.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
hch@lst.de, gost.dev@samsung.com,
Anuj Gupta <anuj20.g@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/read_write: Enable copy_file_range for block device.
Date: Mon, 24 Jul 2023 18:38:38 +0200 [thread overview]
Message-ID: <20230724163838.GB26430@lst.de> (raw)
In-Reply-To: <ZL4cpDxr450zomJ0@dread.disaster.area>
> > Change generic_copy_file_checks to use ->f_mapping->host for both inode_in
> > and inode_out. Allow block device in generic_file_rw_checks.
>
> Why? copy_file_range() is for copying a range of a regular file to
> another regular file - why do we want to support block devices for
> somethign that is clearly intended for copying data files?
Nitesh has a series to add block layer copy offload, and uses that to
implement copy_file_range on block device nodes, which seems like a
sensible use case for copy_file_range on block device nodes, and that
series was hiding a change like this deep down in a "block" title
patch, so I asked for it to be split out. It still really should
be in that series, as there's very little point in changing this
check without an actual implementation making use of it.
next prev parent reply other threads:[~2023-07-24 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230724060655epcas5p24f21ce77480885c746b9b86d27585492@epcas5p2.samsung.com>
2023-07-24 6:03 ` [PATCH] fs/read_write: Enable copy_file_range for block device Nitesh Shetty
2023-07-24 6:39 ` Dave Chinner
2023-07-24 16:38 ` Christoph Hellwig [this message]
2023-07-24 22:08 ` Dave Chinner
2023-07-25 11:48 ` Nitesh Shetty
2023-07-24 16:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724163838.GB26430@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=gost.dev@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nj.shetty@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox