From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
John Stultz <jstultz@google.com>
Subject: Re: [PATCH 2/2] scripts/faddr2line: Use LLVM addr2line and readelf if LLVM=1
Date: Mon, 24 Jul 2023 17:07:49 -0700 [thread overview]
Message-ID: <20230725000749.24qsqlqn5llfan7g@treble> (raw)
In-Reply-To: <20230724174517.15736-3-will@kernel.org>
On Mon, Jul 24, 2023 at 06:45:17PM +0100, Will Deacon wrote:
> GNU utilities cannot necessarily parse objects built by LLVM, which can
> result in confusing errors when using 'faddr2line':
>
> $ CROSS_COMPILE=aarch64-linux-gnu- ./scripts/faddr2line vmlinux do_one_initcall+0xf4/0x260
> aarch64-linux-gnu-addr2line: vmlinux: unknown type [0x13] section `.relr.dyn'
> aarch64-linux-gnu-addr2line: DWARF error: invalid or unhandled FORM value: 0x25
> do_one_initcall+0xf4/0x260:
> aarch64-linux-gnu-addr2line: vmlinux: unknown type [0x13] section `.relr.dyn'
> aarch64-linux-gnu-addr2line: DWARF error: invalid or unhandled FORM value: 0x25
> $x.73 at main.c:?
>
> Although this can be worked around by setting CROSS_COMPILE to "llvm=-",
> it's cleaner to follow the same syntax as the top-level Makefile and
> accept LLVM=1 as an indication to use the llvm- tools.
>
> Cc: Josh Poimboeuf <jpoimboe@kernel.org>
> Cc: John Stultz <jstultz@google.com>
> Signed-off-by: Will Deacon <will@kernel.org>
This one looks good to me, I'll go ahead and queue it.
--
Josh
next prev parent reply other threads:[~2023-07-25 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:45 [PATCH 0/2] Fix 'faddr2line' for LLVM arm64 builds Will Deacon
2023-07-24 17:45 ` [PATCH 1/2] scripts/faddr2line: Ignore non-function symbols in readelf output Will Deacon
2023-07-24 23:47 ` Josh Poimboeuf
2023-07-25 17:21 ` Will Deacon
2023-10-24 8:52 ` [tip: objtool/core] scripts/faddr2line: Don't filter out non-function symbols from readelf tip-bot2 for Will Deacon
2023-07-24 17:45 ` [PATCH 2/2] scripts/faddr2line: Use LLVM addr2line and readelf if LLVM=1 Will Deacon
2023-07-25 0:07 ` Josh Poimboeuf [this message]
2023-07-25 17:21 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725000749.24qsqlqn5llfan7g@treble \
--to=jpoimboe@kernel.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox