From: Greg KH <gregkh@linuxfoundation.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Thinh.Nguyen@synopsys.com, andriy.shevchenko@linux.intel.com,
imx@lists.linux.dev, jgilab@gmail.com, jun.li@nxp.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
peter.chen@kernel.org, quic_eserrao@quicinc.com,
quic_prashk@quicinc.com, r-gunasekaran@ti.com, rogerq@kernel.org
Subject: Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability
Date: Tue, 25 Jul 2023 17:09:30 +0200 [thread overview]
Message-ID: <2023072501-primp-grandson-7f79@gregkh> (raw)
In-Reply-To: <ZL/eF0fZe4k63sXX@lizhi-Precision-Tower-5810>
On Tue, Jul 25, 2023 at 10:37:11AM -0400, Frank Li wrote:
> On Fri, Jul 07, 2023 at 07:00:14PM -0400, Frank Li wrote:
> > The legacy gadget driver omitted calling usb_gadget_check_config()
> > to ensure that the USB device controller (UDC) has adequate resources,
> > including sufficient endpoint numbers and types, to support the given
> > configuration.
> >
> > Previously, usb_add_config() was solely invoked by the legacy gadget
> > driver. Adds the necessary usb_gadget_check_config() after the bind()
> > operation to fix the issue.
> >
> > Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
> > Reported-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
>
> @greg
> ping
It's in my review queue, please give me a chance to catch up.
While you wait, doing review of other USB patches would be most
appreciated.
thanks,
greg k-h
prev parent reply other threads:[~2023-07-25 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 23:00 [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability Frank Li
2023-07-07 23:00 ` [PATCH v2 2/2] usb: cdns3: fix incorrect calculation of ep_buf_size when more than one config Frank Li
[not found] ` <f803653c-8967-b187-8339-fbec0cdeef25@web.de>
2023-07-09 8:06 ` Greg Kroah-Hartman
2023-07-10 3:38 ` Peter Chen
2023-07-10 11:14 ` Ravi Gunasekaran
2023-07-25 14:37 ` [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to verify UDC capability Frank Li
2023-07-25 15:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072501-primp-grandson-7f79@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Frank.li@nxp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=jgilab@gmail.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=quic_prashk@quicinc.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox