From: Raghu Halharvi <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
Alison Schofield <alison.schofield@intel.com>,
raghuhack78@gmail.com, ira.weiny@intel.com, bwidawsk@kernel.org,
dan.j.williams@intel.com, vishal.l.verma@intel.com
Cc: linux-kernel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH RESEND v6 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
Date: Tue, 25 Jul 2023 12:19:29 +0000 [thread overview]
Message-ID: <20230725121930.3732-2-raghuhack78@gmail.com> (raw)
In-Reply-To: <20230725121930.3732-1-raghuhack78@gmail.com>
Issue found with checkpatch
A return of errno should be good enough if the memory allocation fails,
the error message here is redundant as per the coding style, removing
it.
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
---
drivers/cxl/core/mbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index d6d067fbee97..af7f37cea871 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev)
struct cxl_memdev_state *mds;
mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL);
- if (!mds) {
- dev_err(dev, "No memory available\n");
+ if (!mds)
return ERR_PTR(-ENOMEM);
- }
mutex_init(&mds->mbox_mutex);
mutex_init(&mds->event.log_lock);
--
2.39.2
next prev parent reply other threads:[~2023-07-25 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 12:19 [PATCH RESEND v6 0/2] Fixing check patch styling issues Raghu Halharvi
2023-07-25 12:19 ` Raghu Halharvi [this message]
2023-07-25 12:19 ` [PATCH RESEND v6 2/2] cxl/region: Remove else after return statement Raghu Halharvi
2023-07-25 17:55 ` [PATCH RESEND v6 0/2] Fixing check patch styling issues Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725121930.3732-2-raghuhack78@gmail.com \
--to=raghuhack78@gmail.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox