public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Raghu Halharvi <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
	Alison Schofield <alison.schofield@intel.com>,
	raghuhack78@gmail.com, ira.weiny@intel.com, bwidawsk@kernel.org,
	dan.j.williams@intel.com, vishal.l.verma@intel.com
Cc: linux-kernel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH RESEND v6 2/2] cxl/region: Remove else after return statement
Date: Tue, 25 Jul 2023 12:19:30 +0000	[thread overview]
Message-ID: <20230725121930.3732-3-raghuhack78@gmail.com> (raw)
In-Reply-To: <20230725121930.3732-1-raghuhack78@gmail.com>

Issue found with checkpatch

The else section here is redundant after return statement, removing it.
Sanity and correctness is not affected due to this fix.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>

Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
---
 drivers/cxl/core/region.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index e115ba382e04..bfd3b13dd2c1 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -133,11 +133,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
 				&cxlr->dev,
 				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
 			return 0;
-		} else {
-			dev_err(&cxlr->dev,
-				"Failed to synchronize CPU cache state\n");
-			return -ENXIO;
 		}
+
+		dev_err(&cxlr->dev,
+			"Failed to synchronize CPU cache state\n");
+		return -ENXIO;
 	}
 
 	cpu_cache_invalidate_memregion(IORES_DESC_CXL);
-- 
2.39.2


  parent reply	other threads:[~2023-07-25 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 12:19 [PATCH RESEND v6 0/2] Fixing check patch styling issues Raghu Halharvi
2023-07-25 12:19 ` [PATCH RESEND v6 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Raghu Halharvi
2023-07-25 12:19 ` Raghu Halharvi [this message]
2023-07-25 17:55 ` [PATCH RESEND v6 0/2] Fixing check patch styling issues Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725121930.3732-3-raghuhack78@gmail.com \
    --to=raghuhack78@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox