public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrei Coardos <aboutphysycs@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: andy@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org,
	Andrei Coardos <aboutphysycs@gmail.com>,
	Alexandru Ardelean <alex@shruggie.ro>
Subject: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call
Date: Tue, 25 Jul 2023 15:30:45 +0300	[thread overview]
Message-ID: <20230725123045.6367-1-aboutphysycs@gmail.com> (raw)

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/20230720134845.23727-1-aboutphysycs@gmail.com
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-mlxbf2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 6abe01bc39c3..cf91b6e74d88 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
 		}
 	}
 
-	platform_set_drvdata(pdev, gs);
-
 	ret = devm_gpiochip_add_data(dev, &gs->gc, gs);
 	if (ret) {
 		dev_err(dev, "Failed adding memory mapped gpiochip\n");
-- 
2.34.1


             reply	other threads:[~2023-07-25 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 12:30 Andrei Coardos [this message]
2023-07-25 13:13 ` [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call Andy Shevchenko
2023-08-01 19:20   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725123045.6367-1-aboutphysycs@gmail.com \
    --to=aboutphysycs@gmail.com \
    --cc=alex@shruggie.ro \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox