[PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

[PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

[Andrei Coardos]

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/20230720134845.23727-1-aboutphysycs@gmail.com
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-mlxbf2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 6abe01bc39c3..cf91b6e74d88 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
 		}
 	}
 
-	platform_set_drvdata(pdev, gs);
-
 	ret = devm_gpiochip_add_data(dev, &gs->gc, gs);
 	if (ret) {
 		dev_err(dev, "Failed adding memory mapped gpiochip\n");
-- 
2.34.1

Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

[Andy Shevchenko]

On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.

This is simply not true.

NAK.

> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

[Bartosz Golaszewski]

On Tue, Jul 25, 2023 at 3:13 PM Andy Shevchenko <andy@kernel.org> wrote:
>
> On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.
>
> This is simply not true.
>
> NAK.
>

Just so you know if that's not obvious from reading the code:
platform_get_drvdata() is just a wrapper around dev_get_drvdata()
which is called plenty in PM callbacks of this driver.

Bart

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>