From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21720C001DF for ; Tue, 25 Jul 2023 16:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbjGYQgq (ORCPT ); Tue, 25 Jul 2023 12:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbjGYQgn (ORCPT ); Tue, 25 Jul 2023 12:36:43 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE27810CC; Tue, 25 Jul 2023 09:36:42 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 052384AD; Tue, 25 Jul 2023 18:35:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1690302943; bh=+R48A+5seDyRpwPko8HmAprRgULuPwTHhToPh14FLMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TatPvRQ4zCi+d+TLQ0JN6RejRXqWEhsiluClHvvv2O4fReYrOA95HLEe8QvQgEOJr fTzqHCNW7hN57Zdl2AQQI+j5gx9xrVNFsaqFrGa8Iu9QcRZn0BUIKeI8fia33FSHKj i/K8JAo3QZDYnCJySWjlbBc4SAIJErvFqcQXtXoU= Date: Tue, 25 Jul 2023 19:36:49 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: Mauro Carvalho Chehab , Luca Ceresoli , Andy Shevchenko , Sakari Ailus , Hans Verkuil , Satish Nagireddy , Matti Vaittinen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/8] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK Message-ID: <20230725163649.GK31069@pendragon.ideasonboard.com> References: <20230720-fpdlink-additions-v2-0-b91b1eca2ad3@ideasonboard.com> <20230720-fpdlink-additions-v2-4-b91b1eca2ad3@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230720-fpdlink-additions-v2-4-b91b1eca2ad3@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Jul 20, 2023 at 01:30:35PM +0300, Tomi Valkeinen wrote: > Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK flag to configure the CSI-2 RX > continuous/non-continuous clock register. > > Signed-off-by: Tomi Valkeinen > --- > drivers/media/i2c/ds90ub953.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c > index ad964bd6c7eb..ad479923d2b4 100644 > --- a/drivers/media/i2c/ds90ub953.c > +++ b/drivers/media/i2c/ds90ub953.c > @@ -138,6 +138,7 @@ struct ub953_data { > struct regmap *regmap; > > u32 num_data_lanes; > + bool non_cont_clk; Maybe non_continous_clk for consistency with 1/8 ? Reviewed-by: Laurent Pinchart > > struct gpio_chip gpio_chip; > > @@ -1139,6 +1140,9 @@ static int ub953_parse_dt(struct ub953_data *priv) > > priv->num_data_lanes = nlanes; > > + priv->non_cont_clk = vep.bus.mipi_csi2.flags & > + V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK; > + > return 0; > } > > @@ -1201,7 +1205,7 @@ static int ub953_hw_init(struct ub953_data *priv) > return dev_err_probe(dev, ret, "i2c init failed\n"); > > ub953_write(priv, UB953_REG_GENERAL_CFG, > - UB953_REG_GENERAL_CFG_CONT_CLK | > + (priv->non_cont_clk ? 0 : UB953_REG_GENERAL_CFG_CONT_CLK) | > ((priv->num_data_lanes - 1) << UB953_REG_GENERAL_CFG_CSI_LANE_SEL_SHIFT) | > UB953_REG_GENERAL_CFG_CRC_TX_GEN_ENABLE); > > -- Regards, Laurent Pinchart