From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B6BC001DF for ; Tue, 25 Jul 2023 16:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231745AbjGYQiP (ORCPT ); Tue, 25 Jul 2023 12:38:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjGYQiM (ORCPT ); Tue, 25 Jul 2023 12:38:12 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46FA1BDB; Tue, 25 Jul 2023 09:38:11 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CD634AD; Tue, 25 Jul 2023 18:37:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1690303032; bh=Pvi3D2FQ9AgiAljI9g5y72aMEJY7/WXS4skrAkOmGCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VlGXA2gcLYu8+BKOBeDLyJY7fsssy7DXWqhoNBjWlxBwtLLYXGE5W/N5Fe/vmaKXk q6MQpS7vyDBDW8DJOh6KVyacSPvqAmCQcHOejv7W+o3k4ywWDfJJj3z6/iY3AUz1gl +wICd+WQGIRlFOCvHD0SbS5VI9U4qlT0sC+p1C8Y= Date: Tue, 25 Jul 2023 19:38:18 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: Mauro Carvalho Chehab , Luca Ceresoli , Andy Shevchenko , Sakari Ailus , Hans Verkuil , Satish Nagireddy , Matti Vaittinen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2 5/8] media: i2c: ds90ub960: Allow FPD-Link async mode Message-ID: <20230725163818.GL31069@pendragon.ideasonboard.com> References: <20230720-fpdlink-additions-v2-0-b91b1eca2ad3@ideasonboard.com> <20230720-fpdlink-additions-v2-5-b91b1eca2ad3@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230720-fpdlink-additions-v2-5-b91b1eca2ad3@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Jul 20, 2023 at 01:30:36PM +0300, Tomi Valkeinen wrote: > Allow using FPD-Link in async mode. The driver handles it correctly, but > the mode was blocked at probe time as there wasn't HW to test this with. > Now the mode has been tested, and it works. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Andy Shevchenko Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/ds90ub960.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c > index a83091f47140..ea819fb6e99b 100644 > --- a/drivers/media/i2c/ds90ub960.c > +++ b/drivers/media/i2c/ds90ub960.c > @@ -3240,7 +3240,6 @@ ub960_parse_dt_rxport_link_properties(struct ub960_data *priv, > switch (rx_mode) { > case RXPORT_MODE_RAW12_HF: > case RXPORT_MODE_RAW12_LF: > - case RXPORT_MODE_CSI2_ASYNC: > dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport, > rx_mode); > return -EINVAL; > -- Regards, Laurent Pinchart