From: Greg KH <gregkh@linuxfoundation.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()
Date: Wed, 26 Jul 2023 11:42:04 +0200 [thread overview]
Message-ID: <2023072646-valid-quote-d313@gregkh> (raw)
In-Reply-To: <20230726170644.2474917-1-ruanjinjie@huawei.com>
On Wed, Jul 26, 2023 at 05:06:44PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from the platform_get_irq() functions as it
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/misc/hi6421v600-irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
> index caa3de37698b..e5ed94e98a3c 100644
> --- a/drivers/misc/hi6421v600-irq.c
> +++ b/drivers/misc/hi6421v600-irq.c
> @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>
> priv->irq = platform_get_irq(pmic_pdev, 0);
> if (priv->irq < 0) {
> - dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
> return priv->irq;
> }
It's good not to add coding style errors when trying to fix up a
different type of issue :(
next prev parent reply other threads:[~2023-07-26 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:06 [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err() Ruan Jinjie
2023-07-26 9:42 ` Greg KH [this message]
2023-07-26 9:49 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072646-valid-quote-d313@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox