* [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()
@ 2023-07-26 17:06 Ruan Jinjie
2023-07-26 9:42 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Ruan Jinjie @ 2023-07-26 17:06 UTC (permalink / raw)
To: arnd, gregkh, linux-kernel; +Cc: ruanjinjie
There is no need to call the dev_err() function directly to print a custom
message when handling an error from the platform_get_irq() functions as it
going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/misc/hi6421v600-irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index caa3de37698b..e5ed94e98a3c 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
priv->irq = platform_get_irq(pmic_pdev, 0);
if (priv->irq < 0) {
- dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
return priv->irq;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()
2023-07-26 17:06 [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err() Ruan Jinjie
@ 2023-07-26 9:42 ` Greg KH
2023-07-26 9:49 ` Ruan Jinjie
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2023-07-26 9:42 UTC (permalink / raw)
To: Ruan Jinjie; +Cc: arnd, linux-kernel
On Wed, Jul 26, 2023 at 05:06:44PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from the platform_get_irq() functions as it
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/misc/hi6421v600-irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
> index caa3de37698b..e5ed94e98a3c 100644
> --- a/drivers/misc/hi6421v600-irq.c
> +++ b/drivers/misc/hi6421v600-irq.c
> @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>
> priv->irq = platform_get_irq(pmic_pdev, 0);
> if (priv->irq < 0) {
> - dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
> return priv->irq;
> }
It's good not to add coding style errors when trying to fix up a
different type of issue :(
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()
2023-07-26 9:42 ` Greg KH
@ 2023-07-26 9:49 ` Ruan Jinjie
0 siblings, 0 replies; 3+ messages in thread
From: Ruan Jinjie @ 2023-07-26 9:49 UTC (permalink / raw)
To: Greg KH; +Cc: arnd, linux-kernel
On 2023/7/26 17:42, Greg KH wrote:
> On Wed, Jul 26, 2023 at 05:06:44PM +0000, Ruan Jinjie wrote:
>> There is no need to call the dev_err() function directly to print a custom
>> message when handling an error from the platform_get_irq() functions as it
>> going to display an appropriate error message in case of a failure.
>>
>> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
>> ---
>> drivers/misc/hi6421v600-irq.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
>> index caa3de37698b..e5ed94e98a3c 100644
>> --- a/drivers/misc/hi6421v600-irq.c
>> +++ b/drivers/misc/hi6421v600-irq.c
>> @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>>
>> priv->irq = platform_get_irq(pmic_pdev, 0);
>> if (priv->irq < 0) {
>> - dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
>> return priv->irq;
>> }
>
> It's good not to add coding style errors when trying to fix up a
> different type of issue :(
I'll fix the coding style error in v2, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-26 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 17:06 [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err() Ruan Jinjie
2023-07-26 9:42 ` Greg KH
2023-07-26 9:49 ` Ruan Jinjie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox