From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F4DC41513 for ; Thu, 27 Jul 2023 00:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbjG0Avj (ORCPT ); Wed, 26 Jul 2023 20:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbjG0Avh (ORCPT ); Wed, 26 Jul 2023 20:51:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83EA2128; Wed, 26 Jul 2023 17:51:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B01461CE7; Thu, 27 Jul 2023 00:51:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04086C433C7; Thu, 27 Jul 2023 00:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690419095; bh=ZhjqtpIRGSMoW8Oc7K1hWttjjyBxCt0r6PcQ25NEtp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ATiThoRis+jRgtpQW5n1P4JjCWAKCrhdgEvSKVsu6I7i/kFxajtP8ksM21Aq2oeUD 7gkKAKWFMtw5V3cNS0uull4Ew6ZGd3YqMY67F4XV4uDeJCiNQvsUhXUpd9P9WUyq4y 2BPhE7aA28kotCTZVsO/pyXAyC7B/9vdQJsKTCMiqKyBOBgeRUMdJk/FtUm1v7YoDm 7mLBY2uxPhRmWSFdvyRKCdLpnafH/79SKQmvQo1fS++ewWJEKAvWR1OFuvg+yMWDcn sngLg9pGvEkxA8zff54nnbQbLvKOgG8j9Pu/UxwmPONAlMqTU9ZyQKTSlJtlIGslFP u9uxOtqcj0XLg== Date: Thu, 27 Jul 2023 02:51:32 +0200 From: Andi Shyti To: Yangtao Li Cc: Adrian Hunter , Ben Dooks , Jaehoon Chung , Ulf Hansson , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 21/61] mmc: sdhci-s3c: Convert to platform remove callback returning void Message-ID: <20230727005132.sxphs3cdourj3m2f@intel.intel> References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-21-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230726040041.26267-21-frank.li@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yangtao, On Wed, Jul 26, 2023 at 12:00:01PM +0800, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König > Signed-off-by: Yangtao Li Reviewed-by: Andi Shyti Andi