From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Yury Norov <yury.norov@gmail.com>
Subject: [PATCH 1/6] bitmap: fix opencoded bitmap_allocate_region()
Date: Wed, 26 Jul 2023 19:02:02 -0700 [thread overview]
Message-ID: <20230727020207.36314-2-yury.norov@gmail.com> (raw)
In-Reply-To: <20230727020207.36314-1-yury.norov@gmail.com>
bitmap_find_region() opencodes bitmap_allocate_region(). Fix it.
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
lib/bitmap.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index ddb31015e38a..0bed9d943d96 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1314,12 +1314,10 @@ int bitmap_find_free_region(unsigned long *bitmap, unsigned int bits, int order)
{
unsigned int pos, end; /* scans bitmap by regions of size order */
- for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end) {
- if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
- continue;
- __reg_op(bitmap, pos, order, REG_OP_ALLOC);
- return pos;
- }
+ for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end)
+ if (!bitmap_allocate_region(bitmap, pos, order))
+ return pos;
+
return -ENOMEM;
}
EXPORT_SYMBOL(bitmap_find_free_region);
--
2.39.2
next prev parent reply other threads:[~2023-07-27 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 2:02 [PATCH 0/6] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-07-27 2:02 ` Yury Norov [this message]
2023-07-27 10:04 ` [PATCH 1/6] bitmap: fix opencoded bitmap_allocate_region() Andy Shevchenko
2023-07-27 2:02 ` [PATCH 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-07-27 2:02 ` [PATCH 3/6] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-07-27 2:02 ` [PATCH 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-07-27 10:05 ` Andy Shevchenko
2023-07-27 2:02 ` [PATCH 5/6] bitmap: drop _reg_op() function Yury Norov
2023-07-27 2:02 ` [PATCH 6/6] bitmap: move bitmap_*_region functions to bitmap.h Yury Norov
2023-07-27 5:09 ` kernel test robot
2023-07-27 5:20 ` kernel test robot
2023-07-27 10:06 ` Andy Shevchenko
2023-07-27 14:39 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727020207.36314-2-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox