From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
iommu@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 02/12] iommu/arm-smmu-v3: Remove unrecoverable faults reporting
Date: Thu, 27 Jul 2023 13:48:27 +0800 [thread overview]
Message-ID: <20230727054837.147050-3-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230727054837.147050-1-baolu.lu@linux.intel.com>
No device driver registers fault handler to handle the reported
unrecoveraable faults. Remove it to avoid dead code.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 46 ++++++---------------
1 file changed, 13 insertions(+), 33 deletions(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 9b0dc3505601..1a43f904b6b8 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -1469,7 +1469,6 @@ arm_smmu_find_master(struct arm_smmu_device *smmu, u32 sid)
static int arm_smmu_handle_evt(struct arm_smmu_device *smmu, u64 *evt)
{
int ret;
- u32 reason;
u32 perm = 0;
struct arm_smmu_master *master;
bool ssid_valid = evt[0] & EVTQ_0_SSV;
@@ -1479,16 +1478,9 @@ static int arm_smmu_handle_evt(struct arm_smmu_device *smmu, u64 *evt)
switch (FIELD_GET(EVTQ_0_ID, evt[0])) {
case EVT_ID_TRANSLATION_FAULT:
- reason = IOMMU_FAULT_REASON_PTE_FETCH;
- break;
case EVT_ID_ADDR_SIZE_FAULT:
- reason = IOMMU_FAULT_REASON_OOR_ADDRESS;
- break;
case EVT_ID_ACCESS_FAULT:
- reason = IOMMU_FAULT_REASON_ACCESS;
- break;
case EVT_ID_PERMISSION_FAULT:
- reason = IOMMU_FAULT_REASON_PERMISSION;
break;
default:
return -EOPNOTSUPP;
@@ -1498,6 +1490,9 @@ static int arm_smmu_handle_evt(struct arm_smmu_device *smmu, u64 *evt)
if (evt[1] & EVTQ_1_S2)
return -EFAULT;
+ if (!(evt[1] & EVTQ_1_STALL))
+ return -EOPNOTSUPP;
+
if (evt[1] & EVTQ_1_RnW)
perm |= IOMMU_FAULT_PERM_READ;
else
@@ -1509,32 +1504,17 @@ static int arm_smmu_handle_evt(struct arm_smmu_device *smmu, u64 *evt)
if (evt[1] & EVTQ_1_PnU)
perm |= IOMMU_FAULT_PERM_PRIV;
- if (evt[1] & EVTQ_1_STALL) {
- flt->type = IOMMU_FAULT_PAGE_REQ;
- flt->prm = (struct iommu_fault_page_request) {
- .flags = IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE,
- .grpid = FIELD_GET(EVTQ_1_STAG, evt[1]),
- .perm = perm,
- .addr = FIELD_GET(EVTQ_2_ADDR, evt[2]),
- };
+ flt->type = IOMMU_FAULT_PAGE_REQ;
+ flt->prm = (struct iommu_fault_page_request) {
+ .flags = IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE,
+ .grpid = FIELD_GET(EVTQ_1_STAG, evt[1]),
+ .perm = perm,
+ .addr = FIELD_GET(EVTQ_2_ADDR, evt[2]),
+ };
- if (ssid_valid) {
- flt->prm.flags |= IOMMU_FAULT_PAGE_REQUEST_PASID_VALID;
- flt->prm.pasid = FIELD_GET(EVTQ_0_SSID, evt[0]);
- }
- } else {
- flt->type = IOMMU_FAULT_DMA_UNRECOV;
- flt->event = (struct iommu_fault_unrecoverable) {
- .reason = reason,
- .flags = IOMMU_FAULT_UNRECOV_ADDR_VALID,
- .perm = perm,
- .addr = FIELD_GET(EVTQ_2_ADDR, evt[2]),
- };
-
- if (ssid_valid) {
- flt->event.flags |= IOMMU_FAULT_UNRECOV_PASID_VALID;
- flt->event.pasid = FIELD_GET(EVTQ_0_SSID, evt[0]);
- }
+ if (ssid_valid) {
+ flt->prm.flags |= IOMMU_FAULT_PAGE_REQUEST_PASID_VALID;
+ flt->prm.pasid = FIELD_GET(EVTQ_0_SSID, evt[0]);
}
mutex_lock(&smmu->streams_mutex);
--
2.34.1
next prev parent reply other threads:[~2023-07-27 5:51 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 5:48 [PATCH v2 00/12] iommu: Prepare to deliver page faults to user space Lu Baolu
2023-07-27 5:48 ` [PATCH v2 01/12] iommu: Move iommu fault data to linux/iommu.h Lu Baolu
2023-08-03 7:53 ` Tian, Kevin
2023-08-04 2:51 ` Baolu Lu
2023-08-09 16:58 ` Jason Gunthorpe
2023-07-27 5:48 ` Lu Baolu [this message]
2023-07-27 5:48 ` [PATCH v2 03/12] iommu: Remove unrecoverable fault data Lu Baolu
2023-08-03 7:54 ` Tian, Kevin
2023-08-04 2:58 ` Baolu Lu
2023-08-04 3:51 ` Tian, Kevin
2023-08-04 5:34 ` Baolu Lu
2023-08-08 18:39 ` Jason Gunthorpe
2023-08-09 0:01 ` Tian, Kevin
2023-08-09 14:05 ` Jason Gunthorpe
2023-08-09 16:59 ` Jason Gunthorpe
2023-08-10 2:27 ` Baolu Lu
2023-08-10 16:46 ` Jason Gunthorpe
2023-08-11 1:15 ` Baolu Lu
2023-08-11 4:17 ` Tian, Kevin
2023-07-27 5:48 ` [PATCH v2 04/12] iommu: Replace device fault handler with iommu_queue_iopf() Lu Baolu
2023-08-03 7:55 ` Tian, Kevin
2023-08-10 18:22 ` Jason Gunthorpe
2023-08-11 1:23 ` Baolu Lu
2023-08-10 18:33 ` Jason Gunthorpe
2023-08-11 1:25 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 05/12] iommu: Change the return value of dev_iommu_get() Lu Baolu
2023-08-03 7:59 ` Tian, Kevin
2023-08-04 3:10 ` Baolu Lu
2023-08-04 3:55 ` Tian, Kevin
2023-08-04 5:33 ` Baolu Lu
2023-08-09 16:58 ` Jason Gunthorpe
2023-08-10 2:30 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 06/12] iommu: Make dev->fault_param static Lu Baolu
2023-08-03 8:08 ` Tian, Kevin
2023-08-04 3:16 ` Baolu Lu
2023-08-04 3:56 ` Tian, Kevin
2023-08-04 5:34 ` Baolu Lu
2023-08-10 18:20 ` Jason Gunthorpe
2023-08-10 18:46 ` Jason Gunthorpe
2023-08-11 1:43 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 07/12] iommu: Remove iommu_[un]register_device_fault_handler() Lu Baolu
2023-08-03 8:09 ` Tian, Kevin
2023-08-10 18:59 ` Jason Gunthorpe
2023-07-27 5:48 ` [PATCH v2 08/12] iommu: Prepare for separating SVA and IOPF Lu Baolu
2023-08-03 8:16 ` Tian, Kevin
2023-08-04 3:26 ` Baolu Lu
2023-08-08 18:43 ` Jason Gunthorpe
2023-08-09 0:02 ` Tian, Kevin
2023-08-09 10:40 ` Baolu Lu
2023-08-10 2:35 ` Tian, Kevin
2023-08-10 16:47 ` Jason Gunthorpe
2023-08-11 1:53 ` Baolu Lu
2023-08-11 13:27 ` Jason Gunthorpe
2023-08-13 11:19 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 09/12] iommu: Move iopf_handler() to iommu-sva.c Lu Baolu
2023-08-03 8:21 ` Tian, Kevin
2023-08-04 3:28 ` Baolu Lu
2023-08-10 19:02 ` Jason Gunthorpe
2023-08-11 1:55 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 10/12] iommu: Make iommu_queue_iopf() more generic Lu Baolu
2023-08-10 19:07 ` Jason Gunthorpe
2023-08-11 2:21 ` Baolu Lu
2023-08-11 13:29 ` Jason Gunthorpe
2023-08-12 23:18 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 11/12] iommu: Separate SVA and IOPF in Makefile and Kconfig Lu Baolu
2023-08-10 19:09 ` Jason Gunthorpe
2023-07-27 5:48 ` [PATCH v2 12/12] iommu: Add helper to set iopf handler for domain Lu Baolu
2023-08-10 19:18 ` Jason Gunthorpe
2023-08-11 2:40 ` Baolu Lu
2023-08-11 17:14 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727054837.147050-3-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox