From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782BEC04E69 for ; Thu, 27 Jul 2023 09:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbjG0JfJ (ORCPT ); Thu, 27 Jul 2023 05:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233007AbjG0Jet (ORCPT ); Thu, 27 Jul 2023 05:34:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58364EE7; Thu, 27 Jul 2023 02:26:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6600C61DE1; Thu, 27 Jul 2023 09:26:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73D78C433C7; Thu, 27 Jul 2023 09:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690449996; bh=kUXhLysuJz2igAetLsPv8M5l4rwBIHgBRT7Gl31+jf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hFMjnaK+KO2aW3q7hRteUVeYF+wY/QkadPWcAIFz5supd0QI7Oacso1EW+0GcmBfO 1LZNa+nI4IOEUlAGlewGRvRbzkif2vjBcqpFC18p9x11H22TJsrMdiRrAlsRqRBVI2 7AjiwqGeofWgsEhnxUd4EbVwRWozux9e0S8/uJWhFPKI1C4Ib9tiAtw6MZCzpfSCfr qn6R8AR6vTeO5sUDvQi8F3qY14O/tAhekgb4zDcao5CEgQxxoVDcOXZSaqWsR6CiMQ WkGDVIf5Cy5ETIj6Sf+Gp1D9HGUbDW93EVQfUiFE4vIin3/c2mKHP676ByMXgoSsjo C318sLv+1XqHA== Date: Thu, 27 Jul 2023 10:26:31 +0100 From: Lee Jones To: Hans de Goede Cc: Andy Shevchenko , Henning Schild , Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-watchdog@vger.kernel.org, Pavel Machek , Mark Gross , Tobias Schaffner Subject: Re: [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Message-ID: <20230727092631.GB8175@google.com> References: <20230719153518.13073-1-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2023, Hans de Goede wrote: > Hi, > > On 7/19/23 18:06, Andy Shevchenko wrote: > > On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote: > >> change since v1: > >> - switch LED/wdt Kconfig to "default y" > >> - remove guard which could hide whole siemens submenu, and default m > >> > >> This series does two things. It builds up a Kconfig inheritance chain > >> for all platform device drivers, namely Watchdog and LED. And then it > >> puts all Siemens Simatic IPC drivers in the platform/x86/ directory in > >> a subdirectory called "siemens". > >> > >> That is so that users have to flip less config switches, and to ease > >> maintenance. > > > > All three good enough, although I prefer the ordering that 'tristate' > > followed by 'default' without interleaved 'depends on'. I leave it > > to Hans. Other that that, > > Reviewed-by: Andy Shevchenko > > Thank you. > > Lee, Guenter do you want me to take the entire series on top of: > > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=platform-drivers-x86-simatic-ipc (aka ib-pdx86-simatic-v6.6) > > And send an updated pull-req ? Please apply - no PR required for me. > Or shall I take just 3/3 and will you take the Kconfig > changes from 1/3 resp 2/3 directly ? -- Lee Jones [李琼斯]