From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BE5C04A6A for ; Fri, 28 Jul 2023 02:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbjG1CoD (ORCPT ); Thu, 27 Jul 2023 22:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbjG1CoA (ORCPT ); Thu, 27 Jul 2023 22:44:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6570C35B0; Thu, 27 Jul 2023 19:43:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 598D561FB2; Fri, 28 Jul 2023 02:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35AECC433C9; Fri, 28 Jul 2023 02:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690512192; bh=pm8EEJ3QVFbZRsnnFWhbHs7DxRk67vj7nVk7xzm5K6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JY3PNodbQLvsX/IukNSn5Vy8hxvOWmgmZbr57BdemunG/lL+U0h/YWYpcQqnNiRqs mxnwR/BO7w1OkCYLZx2dQtDyjf5FdlCcRWeHJLR3PL56T00W16VIjBaQiDOjdkh9/m aRtXi96h3XHUh1AXrzpgggQa2nBFAsKoUCLjV8crWrW8ThqmXF2PUbJb0vv40fCCkL BjGH0CVYHb7/4fpBAM3VQyp3+5BAQlznyNuwDqjJHO1CSxxiezQygfHrsqRDYgipl5 Q+q38AFIpg3yybJUMpQaNW9jr5Jf2KT5UKwvNtjrIv1+Atw0zGmyxs3vDU3tsyopi6 TE658BcOcHnzA== Date: Thu, 27 Jul 2023 19:43:11 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: Shuah Khan , Naresh Kamboju , "open list:KERNEL SELFTEST FRAMEWORK" , open list , "lkft-triage@lists.linaro.org" , Netdev , clang-built-linux , Shuah Khan , Anders Roxell , "David S. Miller" , Liam Howlett Subject: Re: selftests: connector: proc_filter.c:48:20: error: invalid application of 'sizeof' to an incomplete type 'struct proc_input' Message-ID: <20230727194311.6a51f285@kernel.org> In-Reply-To: References: <799d6088-e28f-f386-6a00-2291304171a2@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jul 2023 01:38:40 +0000 Anjali Kulkarni wrote: > Jakub, > Do I need to revert the -f runtime filter option back to compile time > and commit with that disabled so the selftest compiles on a kernel on > which the new options are not defined? I'm not 100% sure myself on what's the expectations for building selftests against uAPI headers is.. I _think_ that you're supposed to add an -I$something to the CFLAGS in your Makefile. KHDR_INCLUDES maybe? So that the uAPI headers from the build get used (rendered by make headers). Take a look at Documentation/dev-tools/kselftest.rst, I hope the answer is somewhere there.