Re: [PATCH v2 12/13] dt-bindings: drm/msm/gpu: Extend bindings for chip-id

Krzysztof Kozlowski
2023-07-28T07:28:29Z

On 27/07/2023 23:20, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Upcoming GPUs use an opaque chip-id for identifying the GPU.

Examples?

Anyway, I think we should insist here of using something human-readable,
even if Qualcomm/Adreno internally use some weird numbers.

>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 58ca8912a8c3..56b9b247e8c2 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -13,6 +13,12 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - description: |
> + The driver is parsing the compat string for Adreno to
> + figure out the chip-id.
> + items:
> + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$'

{8} should work?

Best regards,
Krzysztof