From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Clark <robdclark@chromium.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Ulf Hansson <ulf.hansson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2 08/13] drm/msm/adreno: Bring the a630 family together
Date: Thu, 27 Jul 2023 14:20:13 -0700 [thread overview]
Message-ID: <20230727212208.102501-9-robdclark@gmail.com> (raw)
In-Reply-To: <20230727212208.102501-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
All of these are derivatives of a630.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 7 ++++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 5deb79924897..f1bb20574018 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -1617,7 +1617,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
SZ_256K - SZ_16K, 0x44000, "dcache");
if (ret)
goto err_memory;
- } else if (adreno_is_a630(adreno_gpu) || adreno_is_a615_family(adreno_gpu)) {
+ } else if (adreno_is_a630_family(adreno_gpu)) {
/* HFI v1, has sptprac */
gmu->legacy = true;
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index aa64bad25a63..fe7afac5b059 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -340,10 +340,11 @@ static inline int adreno_is_a690(const struct adreno_gpu *gpu)
/* The order of args is important here to handle ANY_ID correctly */
return adreno_cmp_rev(ADRENO_REV(6, 9, 0, ANY_ID), gpu->rev);
};
-/* check for a615, a616, a618, a619 or any derivatives */
-static inline int adreno_is_a615_family(const struct adreno_gpu *gpu)
+/* check for a615, a616, a618, a619 or any a630 derivatives */
+static inline int adreno_is_a630_family(const struct adreno_gpu *gpu)
{
- return adreno_is_revn(gpu, 615) ||
+ return adreno_is_revn(gpu, 630) ||
+ adreno_is_revn(gpu, 615) ||
adreno_is_revn(gpu, 616) ||
adreno_is_revn(gpu, 618) ||
adreno_is_revn(gpu, 619);
--
2.41.0
next prev parent reply other threads:[~2023-07-27 21:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 21:20 [PATCH v2 00/13] drm/msm/adreno: Move away from legacy revision matching Rob Clark
2023-07-27 21:20 ` [PATCH v2 01/13] drm/msm/adreno: Remove GPU name Rob Clark
2023-07-27 21:20 ` [PATCH v2 02/13] drm/msm/adreno: Remove redundant gmem size param Rob Clark
2023-07-27 22:07 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 03/13] drm/msm/adreno: Remove redundant revn param Rob Clark
2023-07-27 21:20 ` [PATCH v2 04/13] drm/msm/adreno: Use quirk identify hw_apriv Rob Clark
2023-07-27 21:20 ` [PATCH v2 05/13] drm/msm/adreno: Use quirk to identify cached-coherent support Rob Clark
2023-07-27 22:08 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 06/13] drm/msm/adreno: Allow SoC specific gpu device table entries Rob Clark
2023-07-27 22:12 ` Dmitry Baryshkov
2023-07-28 15:43 ` Rob Clark
2023-07-27 21:20 ` [PATCH v2 07/13] drm/msm/adreno: Move speedbin mapping to device table Rob Clark
2023-07-27 22:12 ` Dmitry Baryshkov
2023-07-27 21:20 ` Rob Clark [this message]
2023-07-27 21:20 ` [PATCH v2 09/13] drm/msm/adreno: Add adreno family Rob Clark
2023-07-27 22:15 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 10/13] drm/msm/adreno: Add helper for formating chip-id Rob Clark
2023-07-27 21:20 ` [PATCH v2 11/13] drm/msm/adreno: Move adreno info to config Rob Clark
2023-07-27 22:50 ` Dmitry Baryshkov
2023-07-27 21:20 ` [PATCH v2 12/13] dt-bindings: drm/msm/gpu: Extend bindings for chip-id Rob Clark
2023-07-28 7:27 ` Krzysztof Kozlowski
2023-07-28 15:29 ` Rob Clark
2023-07-27 21:20 ` [PATCH v2 13/13] drm/msm/adreno: Switch to chip-id for identifying GPU Rob Clark
2023-08-04 15:28 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727212208.102501-9-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=sean@poorly.run \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox