public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexon Oliveira <alexondunkan@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis
Date: Thu, 27 Jul 2023 19:21:08 +0200	[thread overview]
Message-ID: <2023072752-stem-pupil-76ab@gregkh> (raw)
In-Reply-To: <ZMKkgItqf8r8BcRB@alolivei-thinkpadt480s.gru.csb>

On Thu, Jul 27, 2023 at 02:08:16PM -0300, Alexon Oliveira wrote:
> On Thu, Jul 27, 2023 at 05:05:03PM +0200, Greg KH wrote:
> > You resolved one warning by replacing it with a different one, that's
> > not good :(
> 
> Well, honestly, I couldn't spot any new issue caused by this patch. At least it was not reported by the checkpatch.pl. The ones that are still showing up were already there. But, to move on, if you think it's more productive, I can fix all warnings and checks reported by the checkpatch.pl and send them over in only one patch. Is it that feasible?

I would have thought you would get a "line is too long" warning, that
didn't happen?

Anyway, no, you can't send a "fix all the issues at once" patch, sorry,
if you do that you will get a message from my patch bot that says:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

So please break it up into logical changes.

thanks,

greg k-h

  reply	other threads:[~2023-07-27 17:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-08  3:55 [PATCH] staging: vme_user: fix check alignment should match open parenthesis Alexon Oliveira
2023-07-27  8:03 ` Greg KH
2023-07-27 14:47   ` Alexon Oliveira
2023-07-27 15:05     ` Greg KH
2023-07-27 17:08       ` Alexon Oliveira
2023-07-27 17:21         ` Greg KH [this message]
2023-07-27 17:37           ` Alexon Oliveira
2023-07-28  5:24             ` Dan Carpenter
2023-07-28 17:43               ` Alexon Oliveira
2023-07-28 17:59                 ` Dan Carpenter
2023-08-01 15:53                   ` Alexon Oliveira
  -- strict thread matches above, loose matches on Subject: below --
2023-08-04 21:20 Alexon Oliveira
2023-08-05  6:14 ` Greg KH
2023-08-07 15:13   ` Alexon Oliveira
2023-08-07 15:26     ` Greg KH
2023-08-07 20:30       ` Alexon Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023072752-stem-pupil-76ab@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexondunkan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox