From: Shuah Khan <skhan@linuxfoundation.org>
To: shuah@kernel.org, Liam.Howlett@oracle.com,
anjali.k.kulkarni@oracle.com, kuba@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip
Date: Fri, 28 Jul 2023 18:24:03 -0600 [thread overview]
Message-ID: <20230729002403.4278-1-skhan@linuxfoundation.org> (raw)
Fix input argument parsing paths to skip from their error legs.
This fix helps to avoid false test failure reports without running
the test.
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
v2: Removed root check based on Anjali's review comments.
Add netdev to RESEND
tools/testing/selftests/connector/proc_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
index 4fe8c6763fd8..4a825b997666 100644
--- a/tools/testing/selftests/connector/proc_filter.c
+++ b/tools/testing/selftests/connector/proc_filter.c
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])
if (argc > 2) {
printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
if (argc == 2) {
@@ -256,7 +256,7 @@ int main(int argc, char *argv[])
filter = 1;
} else {
printf("Valid option : -f (for filter feature)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
}
--
2.39.2
next reply other threads:[~2023-07-29 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 0:24 Shuah Khan [this message]
2023-07-31 20:23 ` [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip Shuah Khan
2023-07-31 21:07 ` Jakub Kicinski
2023-07-31 21:57 ` Anjali Kulkarni
2023-07-31 21:57 ` Anjali Kulkarni
2023-08-01 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729002403.4278-1-skhan@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox