From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB60C001DC for ; Sat, 29 Jul 2023 07:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235926AbjG2H23 (ORCPT ); Sat, 29 Jul 2023 03:28:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjG2H20 (ORCPT ); Sat, 29 Jul 2023 03:28:26 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3CA9E49D5 for ; Sat, 29 Jul 2023 00:28:25 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 36T7SGk7004141; Sat, 29 Jul 2023 09:28:16 +0200 Date: Sat, 29 Jul 2023 09:28:16 +0200 From: Willy Tarreau To: Mark Brown Cc: Ryan Roberts , Andrew Morton , Naresh Kamboju , linux-kernel@vger.kernel.org, Linux Kernel Functional Testing Subject: Re: [PATCH v1] tools/nolibc/stdio: add setvbuf() to set buffering mode Message-ID: <20230729072816.GE956@1wt.eu> References: <20230726070655.2713530-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 12:46:16PM +0100, Mark Brown wrote: > On Wed, Jul 26, 2023 at 08:06:55AM +0100, Ryan Roberts wrote: > > Add a minimal implementation of setvbuf(), which error checks the mode > > argument (as required by spec) and returns. Since nolibc never buffers > > output, nothing needs to be done. > > Reviewed-by: Mark Brown Looks good and queued, thanks to you both! Willy