From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: Zhangjin Wu <falcon@tinylab.org>,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 12/12] selftests/nolibc: speed up some targets with multiple jobs
Date: Sat, 29 Jul 2023 10:31:28 +0200 [thread overview]
Message-ID: <20230729083128.GM956@1wt.eu> (raw)
In-Reply-To: <ce2f10ad-bbdf-4948-b784-b497e8973e6e@t-8ch.de>
On Sat, Jul 29, 2023 at 08:44:32AM +0200, Thomas Weißschuh wrote:
> On 2023-07-28 04:35:01+0800, Zhangjin Wu wrote:
> > The sysroot install and kernel build targets are time cost, let's use
> > -j<N> to parallelize them with multiple jobs.
> >
> > Signed-off-by: Zhangjin Wu <falcon@tinylab.org>
> > ---
> > tools/testing/selftests/nolibc/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> > index ad2538ec5eb0..1b45c22f9a94 100644
> > --- a/tools/testing/selftests/nolibc/Makefile
> > +++ b/tools/testing/selftests/nolibc/Makefile
> > @@ -171,7 +171,7 @@ PHONY = sysroot/$(ARCH)/include
> > sysroot/$(ARCH)/include:
> > $(Q)rm -rf sysroot/$(ARCH) sysroot/sysroot
> > $(QUIET_MKDIR)mkdir -p sysroot
> > - $(Q)$(MAKE) -C ../../../include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
> > + $(Q)$(MAKE) -j$$(nproc) -C ../../../include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
>
> This should already work when the users specify -j on the make command
> line themselves.
> I'm not a fan of force-enabling it here.
Indeed, we must not do that, because some users might for instance
prefer to build multiple archs in parallel and benefit from a better
parallelism and now they'd end up with too many processes.
Willy
next prev parent reply other threads:[~2023-07-29 8:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 20:21 [PATCH v3 00/12] selftests/nolibc: add minimal kernel config support - part1 Zhangjin Wu
2023-07-27 20:22 ` [PATCH v3 01/12] selftests/nolibc: allow report with existing test log Zhangjin Wu
2023-07-29 6:28 ` Thomas Weißschuh
2023-07-29 8:53 ` Zhangjin Wu
2023-07-27 20:23 ` [PATCH v3 02/12] selftests/nolibc: add macros to reduce duplicated changes Zhangjin Wu
2023-07-27 20:24 ` [PATCH v3 03/12] selftests/nolibc: fix up O= option support Zhangjin Wu
2023-07-27 20:26 ` [PATCH v3 04/12] selftests/nolibc: string the core targets Zhangjin Wu
2023-07-27 20:27 ` [PATCH v3 05/12] selftests/nolibc: allow customize CROSS_COMPILE by architecture Zhangjin Wu
2023-07-27 20:28 ` [PATCH v3 06/12] selftests/nolibc: customize CROSS_COMPILE for 32/64-bit powerpc Zhangjin Wu
2023-07-29 8:35 ` Willy Tarreau
2023-07-29 8:46 ` Zhangjin Wu
2023-07-27 20:29 ` [PATCH v3 07/12] selftests/nolibc: add menuconfig and mrproper for development Zhangjin Wu
2023-07-27 20:30 ` [PATCH v3 08/12] selftests/nolibc: allow quit qemu-system when poweroff fails Zhangjin Wu
2023-07-28 19:40 ` Zhangjin Wu
2023-07-29 7:59 ` Thomas Weißschuh
2023-07-29 8:29 ` Willy Tarreau
2023-07-29 12:05 ` Zhangjin Wu
2023-07-29 17:06 ` Willy Tarreau
2023-07-30 22:28 ` Zhangjin Wu
2023-07-27 20:31 ` [PATCH v3 09/12] selftests/nolibc: customize QEMU_TIMEOUT for ppc64/ppc64le Zhangjin Wu
2023-07-27 20:32 ` [PATCH v3 10/12] selftests/nolibc: tinyconfig: add extra common options Zhangjin Wu
2023-07-27 20:33 ` [PATCH v3 11/12] selftests/nolibc: tinyconfig: add support for 32/64-bit powerpc Zhangjin Wu
2023-07-27 20:35 ` [PATCH v3 12/12] selftests/nolibc: speed up some targets with multiple jobs Zhangjin Wu
2023-07-29 6:44 ` Thomas Weißschuh
2023-07-29 8:31 ` Willy Tarreau [this message]
2023-07-29 9:11 ` Zhangjin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729083128.GM956@1wt.eu \
--to=w@1wt.eu \
--cc=arnd@arndb.de \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox