From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A7DC0015E for ; Sat, 29 Jul 2023 17:10:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbjG2RKa (ORCPT ); Sat, 29 Jul 2023 13:10:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjG2RK0 (ORCPT ); Sat, 29 Jul 2023 13:10:26 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3348DE75; Sat, 29 Jul 2023 10:10:25 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 36THAHYt005396; Sat, 29 Jul 2023 19:10:17 +0200 Date: Sat, 29 Jul 2023 19:10:17 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, thomas@t-8ch.de Subject: Re: [PATCH v3 3/7] selftests/nolibc: add extra configs customize support Message-ID: <20230729171017.GC5219@1wt.eu> References: <20230729162907.GA5219@1wt.eu> <20230729165445.88073-1-falcon@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729165445.88073-1-falcon@tinylab.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 30, 2023 at 12:54:45AM +0800, Zhangjin Wu wrote: > > Also I find it odd to use $(ARCH) here, I would have expected $(XARCH) > > since you probably want to distinguish ppc64 from ppc for example. > > > > Yes, we do, but the XARCH and ARCH mmapping patch is the 4th, will > update this to XARCH, this one is the 3th one, do we need to add this > one after the 4th one? OK indeed it's the 4th one that will modify this one then, no need to reorder. > > > > something like "make nolibctestconfig" to make an existing config ready for > > > > nolibc-test. > > > > > > Do you mean rename 'defconfig' to 'nolibctestconfig'? or something > > > nolibc-test-config: > > > > > > nolibc-test-config: > > > $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) mrproper $(DEFCONFIG) prepare > > > $(Q)$(srctree)/scripts/kconfig/merge_config.sh -O "$(srctree)" -m "$(srctree)/.config" $(foreach c,$(EXTRA_CONFIG),$(wildcard $(CURDIR)/configs/$c)) > > > $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) KCONFIG_ALLCONFIG="$(srctree)/.config" allnoconfig > > > > > > It looks too long ;-) > > > > I think that as long as we don't claim to call topdir's makefile targets > > from this directory, we can reuse some similarly named targets which are > > documented in "make help" and are non-ambiguous. > > Seems 'nolibc-test-config' is really more meaningful than 'defconfig', especially > when we want to use tinyconfig through it? > > $ make nolibc-test-config DEFCONFIG=tinyconfig As a user, I'd ask "why not make tinyconfig" ? But see my other message, now I'm having strong doubts about the relevance of tinyconfig if it works as bad as you described it. Willy