From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E93C001E0 for ; Sat, 29 Jul 2023 17:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjG2RPj (ORCPT ); Sat, 29 Jul 2023 13:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjG2RPh (ORCPT ); Sat, 29 Jul 2023 13:15:37 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9307230E2; Sat, 29 Jul 2023 10:15:35 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 36THFR04005408; Sat, 29 Jul 2023 19:15:27 +0200 Date: Sat, 29 Jul 2023 19:15:27 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, thomas@t-8ch.de Subject: Re: [PATCH v2 08/14] selftests/nolibc: string the core targets Message-ID: <20230729171527.GD5219@1wt.eu> References: <20230729075350.GI956@1wt.eu> <20230729095447.9414-1-falcon@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729095447.9414-1-falcon@tinylab.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 29, 2023 at 05:54:47PM +0800, Zhangjin Wu wrote: > The 'defconfig' will only be triggered while there is no .config there, > I do think it is important, at the first time of using nolibc, I > directly run kernel but it fails for it has a manual defconfig > requirement every time, so, I do think a default defconfig for kernel > for the first run or after a mrproper is helpful, it doesn't modify any > .config for there is no one there. On the opposite, that's yet another example of automatic stuff that for me adds zero value and just doubts in the user's head: "is it safe to call this with my own config or should I keep a safe copy of it?", "what will it use for the config?", "will the arch be correct if my current config references 32BIT and the generated default one switches it to 64?" etc. Please let's not add unneeded dependencies and chaining. It does not help and makes it harder to restart at one specific step, thus lowers the overall value. Willy