From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE34C001DC for ; Sun, 30 Jul 2023 13:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjG3N00 (ORCPT ); Sun, 30 Jul 2023 09:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbjG3N0Y (ORCPT ); Sun, 30 Jul 2023 09:26:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8290EE7F; Sun, 30 Jul 2023 06:26:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C91A60C4D; Sun, 30 Jul 2023 13:26:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCE86C433C8; Sun, 30 Jul 2023 13:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690723582; bh=WwgLymzmxnBrZ9f6hsSKR6h4CTJfMx2hwDOS2SI6yYE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A1b6917DMvdT8q0WB5fzqseyK0S1MaHxzqi5+CXsvOnDO8nCLXqVTc+l10YoM7Ro8 TkLEm/AAJ4+ouDUj5DlLexfFGDmXGieMDuNjx37pvewyfCZA5KzgKLZVqfALFuEt8u 3gWFKgCExmC/wvoBjxp+pOBwmSsuG+/4W5NSn4K5IEgl7IpBK7mYKQqcf4Y3SVWwvU o+KXgmFhjqUCMK2jnKaqceBr6vwr925vXvJ+5NUFH1cXSyX+dIGVUkjCSTET5EZIBH Yo8TJnz/aYt226jX0RkOz6LIwfrqY+jHHxWYMrXbLrWHvHpsIbATznJNfDZtK8rEW1 X+3D9dBVNQm/Q== Date: Sun, 30 Jul 2023 21:26:11 +0800 From: Shawn Guo To: Xiaolei Wang Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, richardcochran@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: dts: imx: Set default tuning step for imx7d usdhc Message-ID: <20230730132611.GR151430@dragon> References: <20230724154510.2532561-1-xiaolei.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724154510.2532561-1-xiaolei.wang@windriver.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 11:45:10PM +0800, Xiaolei Wang wrote: > If the tuning step is not set, the tuning step is set to 1. > For some sd cards, the following Tuning timeout will occur. > > Tuning failed, falling back to fixed sampling clock > mmc0: Tuning failed, falling back to fixed sampling clock > > So set the default tuning step. This refers to the NXP vendor's > commit below: > > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/ > arch/arm/boot/dts/imx7s.dtsi#L1216-L1217 > > Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting") > Signed-off-by: Xiaolei Wang > Reviewed-by: Fabio Estevam Applied, thanks!