From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0ACC001E0 for ; Mon, 31 Jul 2023 15:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231411AbjGaPNW (ORCPT ); Mon, 31 Jul 2023 11:13:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbjGaPNT (ORCPT ); Mon, 31 Jul 2023 11:13:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105B21702; Mon, 31 Jul 2023 08:13:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A238761197; Mon, 31 Jul 2023 15:13:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E584C433C7; Mon, 31 Jul 2023 15:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690816398; bh=MrF8t4t8uZvmRiF8M4pqprmOZSgb4oSYLczB3T4NgPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eYuSN8EF6dbJJwz5kYvjtRQHEirq5FstpPilnFRsZt1Eh6QBnsOyYNSwMbskHFPyC hAIEAhlQcHT9Chsxo9VdFI1VgjpH0GrUHKRECmuEBvFz7dZHVlX6RIGUEzcBsbEpS8 paqhOgiC2Yxfj+uN/q1+ZAGLqfFJf8t2cHm3l07Y= Date: Mon, 31 Jul 2023 17:13:15 +0200 From: "gregkh@linuxfoundation.org" To: Sherry Sun Cc: Jiri Slaby , "tomonori.sakita@sord.co.jp" , "atsushi.nemoto@sord.co.jp" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms Message-ID: <2023073106-disallow-sketch-c5cf@gregkh> References: <20230731015053.15150-1-sherry.sun@nxp.com> <51a7f260-59f9-2cd4-9d49-484df00fb3b2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023 at 05:50:46AM +0000, Sherry Sun wrote: > > > > -----Original Message----- > > From: Jiri Slaby > > Sent: 2023年7月31日 13:24 > > To: Sherry Sun ; gregkh@linuxfoundation.org; > > tomonori.sakita@sord.co.jp; atsushi.nemoto@sord.co.jp > > Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > > > > Subject: Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 > > for lpuart32 platforms > > > > On 31. 07. 23, 3:50, Sherry Sun wrote: > > > Do not read the data register to clear the error flags for lpuart32 > > > platforms, the additional read may cause the receive FIFO underflow > > > since the DMA has already read the data register. > > > Now all lpuart32 platforms support write 1 to clear those error bits, > > > > What does this "Now" mean? Will this change break some older platforms? > > Hi Jiri, > > Sorry for the confusion, maybe the "Now" should be removed here. I can > send a V2 to improve the commit message if needed. Please do, thanks! greg k-h