* [PATCH] thunderbolt: set variable tmu_params storage class specifier to static
@ 2023-07-02 19:06 Tom Rix
2023-07-31 11:14 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-07-02 19:06 UTC (permalink / raw)
To: andreas.noever, michael.jamet, mika.westerberg, YehezkelShB
Cc: linux-usb, linux-kernel, Tom Rix
smatch reports
drivers/thunderbolt/tmu.c:30:3: warning: symbol
'tmu_params' was not declared. Should it be static?
This variable is only used in its defining file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/thunderbolt/tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/tmu.c b/drivers/thunderbolt/tmu.c
index 1269f417515b..c789024d7ffe 100644
--- a/drivers/thunderbolt/tmu.c
+++ b/drivers/thunderbolt/tmu.c
@@ -19,7 +19,7 @@ static const unsigned int tmu_rates[] = {
[TB_SWITCH_TMU_MODE_MEDRES_ENHANCED_UNI] = 16,
};
-const struct {
+static const struct {
unsigned int freq_meas_window;
unsigned int avg_const;
unsigned int delta_avg_const;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thunderbolt: set variable tmu_params storage class specifier to static
2023-07-02 19:06 [PATCH] thunderbolt: set variable tmu_params storage class specifier to static Tom Rix
@ 2023-07-31 11:14 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2023-07-31 11:14 UTC (permalink / raw)
To: Tom Rix; +Cc: andreas.noever, michael.jamet, YehezkelShB, linux-usb,
linux-kernel
On Sun, Jul 02, 2023 at 03:06:08PM -0400, Tom Rix wrote:
> smatch reports
> drivers/thunderbolt/tmu.c:30:3: warning: symbol
> 'tmu_params' was not declared. Should it be static?
>
> This variable is only used in its defining file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-31 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-02 19:06 [PATCH] thunderbolt: set variable tmu_params storage class specifier to static Tom Rix
2023-07-31 11:14 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox