From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
syzbot <syzbot+69c477e882e44ce41ad9@syzkaller.appspotmail.com>,
brauner@kernel.org, chao@kernel.org, huyue2@coolpad.com,
jack@suse.cz, jefflexu@linux.alibaba.com, linkinjeon@kernel.org,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, sj1557.seo@samsung.com,
syzkaller-bugs@googlegroups.com, xiang@kernel.org
Subject: Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb
Date: Mon, 31 Jul 2023 13:16:22 +0200 [thread overview]
Message-ID: <20230731111622.GA3511@lst.de> (raw)
In-Reply-To: <9b57e5f7-62b6-fd65-4dac-a71c9dc08abc@linux.alibaba.com>
On Mon, Jul 31, 2023 at 06:58:14PM +0800, Gao Xiang wrote:
> Previously, deactivate_locked_super() or .kill_sb() will only be
> called after fill_super is called, and .s_magic will be set at
> the very beginning of erofs_fc_fill_super().
>
> After ("fs: open block device after superblock creation"), such
> convension is changed now. Yet at a quick glance,
>
> WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
>
> in erofs_kill_sb() can be removed since deactivate_locked_super()
> will also be called if setup_bdev_super() is falled. I'd suggest
> that removing this WARN_ON() in the related commit, or as
> a following commit of the related branch of the pull request if
> possible.
Agreed. I wonder if we should really call into ->kill_sb before
calling into fill_super, but I need to carefull look into the
details.
next prev parent reply other threads:[~2023-07-31 11:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 7:57 [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb syzbot
2023-07-31 9:37 ` Christoph Hellwig
2023-07-31 10:58 ` Gao Xiang
2023-07-31 11:16 ` Christoph Hellwig [this message]
2023-07-31 12:43 ` Christian Brauner
2023-07-31 13:22 ` Christian Brauner
2023-07-31 13:53 ` Christoph Hellwig
2023-07-31 13:57 ` Christian Brauner
2023-07-31 16:32 ` Christian Brauner
2023-08-01 1:47 ` [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb() Gao Xiang
2023-08-01 7:19 ` Christian Brauner
2023-08-01 7:51 ` Christoph Hellwig
2023-07-31 13:29 ` [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb Gao Xiang
2023-08-29 3:40 ` Gao Xiang
2023-08-29 4:14 ` [syzbot] [erofs?] " syzbot
2023-08-29 5:32 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731111622.GA3511@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=jack@suse.cz \
--cc=jefflexu@linux.alibaba.com \
--cc=linkinjeon@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=syzbot+69c477e882e44ce41ad9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox