From: Jakub Kicinski <kuba@kernel.org>
To: Tahsin Erdogan <trdgn@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tun: avoid high-order page allocation for packet header
Date: Mon, 31 Jul 2023 13:58:54 -0700 [thread overview]
Message-ID: <20230731135854.3628918b@kernel.org> (raw)
In-Reply-To: <20230726030936.1587269-1-trdgn@amazon.com>
On Tue, 25 Jul 2023 20:09:36 -0700 Tahsin Erdogan wrote:
> @@ -1838,6 +1838,9 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
> */
> zerocopy = false;
> } else {
> + if (linear == 0)
> + linear = min_t(size_t, good_linear, copylen);
nit: would you mind changing to !linear instead of linear == 0 ?
Also - I don't see linear explicitly getting set to 0. What guarantees
that? What's the story there?
Otherwise seems reasonable. One more allocation but hopefully nobody
will notice.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-31 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 3:09 [PATCH] tun: avoid high-order page allocation for packet header Tahsin Erdogan
2023-07-31 20:58 ` Jakub Kicinski [this message]
2023-07-31 23:03 ` Erdogan, Tahsin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731135854.3628918b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trdgn@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox