From: Kees Cook <keescook@chromium.org>
To: Petr Tesarik <petrtesarik@huaweicloud.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@kernel.org>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Ian Lin <ian.lin@infineon.com>,
Wright Feng <wright.feng@cypress.com>,
Hector Martin <marcan@marcan.st>,
Prasanna Kerekoppa <prasanna.kerekoppa@cypress.com>,
Hans de Goede <hdegoede@redhat.com>,
Ramesh Rangavittal <ramesh.rangavittal@infineon.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Ryohei Kondo <ryohei.kondo@cypress.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Brian Henriquez <brian.henriquez@cypress.com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<SHA-cyfmac-dev-list@infineon.com>,
open list <linux-kernel@vger.kernel.org>,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
petr@tesarici.cz, Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH v1 3/3] wifi: brcm80211: change channel_list to a flexible array
Date: Tue, 1 Aug 2023 10:30:27 -0700 [thread overview]
Message-ID: <202308011028.BC462D29E@keescook> (raw)
In-Reply-To: <c18a31a293fb5ba5d7a845c4b5052516ff724a9f.1690904067.git.petr.tesarik.ext@huawei.com>
On Tue, Aug 01, 2023 at 05:36:42PM +0200, Petr Tesarik wrote:
> From: Petr Tesarik <petr.tesarik.ext@huawei.com>
>
> The channel list is in fact a flexible array, but it has a length of 1 to
> make sure there is enough room for the special chanspec -1 when the struct
> is allocated on stack to abort a scan.
There is patch series proposing a way to put flex array structures with
a compile-time-known size on the stack. Would that help for this series?
https://lore.kernel.org/netdev/20230801111923.118268-1-przemyslaw.kitszel@intel.com/
-Kees
>
--
Kees Cook
next prev parent reply other threads:[~2023-08-01 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 15:36 [PATCH v1 0/3] wifi: brcm80211: avoid memcpy warning when CONFIG_FORTIFY_SOURCE=y Petr Tesarik
2023-08-01 15:36 ` [PATCH v1 1/3] wifi: brcm80211: drop struct brcmf_p2p_scan_le Petr Tesarik
2023-08-01 17:57 ` Petr Tesarik
2023-08-02 0:08 ` Franky Lin
2023-08-02 6:30 ` Petr Tesařík
2023-08-01 15:36 ` [PATCH v1 2/3] wifi: brcm80211: separate abort scan param prepare from actual scan Petr Tesarik
2023-08-01 15:36 ` [PATCH v1 3/3] wifi: brcm80211: change channel_list to a flexible array Petr Tesarik
2023-08-01 17:30 ` Kees Cook [this message]
2023-08-01 17:37 ` Kalle Valo
2023-08-01 17:55 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308011028.BC462D29E@keescook \
--to=keescook@chromium.org \
--cc=Jason@zx2c4.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brian.henriquez@cypress.com \
--cc=chi-hsien.lin@infineon.com \
--cc=djwong@kernel.org \
--cc=franky.lin@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=ian.lin@infineon.com \
--cc=jgg@ziepe.ca \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=petr@tesarici.cz \
--cc=petrtesarik@huaweicloud.com \
--cc=prasanna.kerekoppa@cypress.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=ramesh.rangavittal@infineon.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=ryohei.kondo@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox