From: Manivannan Sadhasivam <mani@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
andersson@kernel.org, konrad.dybcio@linaro.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Brian Masney <bmasney@redhat.com>
Subject: Re: [PATCH 2/2] scsi: ufs: qcom: Add support for scaling interconnects
Date: Wed, 2 Aug 2023 09:33:53 +0530 [thread overview]
Message-ID: <20230802040353.GA2370@thinkpad> (raw)
In-Reply-To: <43cd0057-c6d8-bc92-08f4-d767336d2cfe@acm.org>
On Mon, Jul 31, 2023 at 01:09:52PM -0700, Bart Van Assche wrote:
> On 7/31/23 07:50, Manivannan Sadhasivam wrote:
> > +struct __ufs_qcom_bw_table {
> > + u32 mem_bw;
> > + u32 cfg_bw;
> > +} ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {
> > + [MODE_MIN][0][0] = { 0, 0 }, /* Bandwidth values in KB/s */
> > + [MODE_PWM][UFS_PWM_G1][UFS_LANE_1] = { 922, 1000 },
> > + [MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844, 1000 },
> > + [MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688, 1000 },
> > + [MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376, 1000 },
> > + [MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844, 1000 },
> > + [MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688, 1000 },
> > + [MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376, 1000 },
> > + [MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752, 1000 },
> > + [MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796, 1000 },
> > + [MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591, 1000 },
> > + [MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
> > + [MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
> > + [MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591, 1000 },
> > + [MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181, 1000 },
> > + [MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
> > + [MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
> > + [MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422, 1000 },
> > + [MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189, 1000 },
> > + [MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
> > + [MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
> > + [MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189, 1000 },
> > + [MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378, 1000 },
> > + [MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
> > + [MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
> > + [MODE_MAX][0][0] = { 7643136, 307200 },
> > +};
>
> Why has the above data structure not been declared as 'static const'?
>
Missed that! Sent a patch now. Thanks for spotting.
- Mani
> Thanks,
>
> Bart.
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-08-02 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 14:50 [PATCH 0/2] scsi: ufs: qcom: Add interconnect support Manivannan Sadhasivam
2023-07-31 14:50 ` [PATCH 1/2] scsi: ufs: core: Add enums for UFS lanes Manivannan Sadhasivam
2023-07-31 14:50 ` [PATCH 2/2] scsi: ufs: qcom: Add support for scaling interconnects Manivannan Sadhasivam
2023-07-31 20:09 ` Bart Van Assche
2023-08-02 4:03 ` Manivannan Sadhasivam [this message]
2023-07-31 18:47 ` [PATCH 0/2] scsi: ufs: qcom: Add interconnect support Martin K. Petersen
2023-08-08 2:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802040353.GA2370@thinkpad \
--to=mani@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox