From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA13DC001E0 for ; Wed, 2 Aug 2023 14:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234447AbjHBOwO (ORCPT ); Wed, 2 Aug 2023 10:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233900AbjHBOwN (ORCPT ); Wed, 2 Aug 2023 10:52:13 -0400 Received: from mgamail.intel.com (unknown [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DC02E43 for ; Wed, 2 Aug 2023 07:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690987932; x=1722523932; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7O8wsYLgsT8lGZDwBvYyoxU7lwdC5FqCYczmgEG4628=; b=A+IDUdOtMfEdfbf2/m3rYTjXclBoJ63/jJzmywCdsx+lfb73WyDcWvrn 0P4d4qI0U+oDYmydDw2us3LCKj6N4WdU4wK0sztt2z2T7g4DxnXDPmJCy /Wtdnn+ZSmu1A40A2EJW2bGIbJG5wO2w0PWWYWSbl5LURrh4xzQd7H7tN 2KgrMJr8X+TIKkwp8GFIFGS/p4YbupUQiJAmNB6VE6dxxo9+QHhhekKAq pja1BGUJCqXP4IHa2ljc4OtlITX/QnInIh9QbtqT3pHYuwc2ora7gNXrE G06YOAvd0rdz33u6iq/5g1NVcb2rKKwthdFtX3PhE3RCy5lgaas7XkAN8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="400552407" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="400552407" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 07:49:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="722869945" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="722869945" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.24.100.114]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 07:48:49 -0700 Date: Wed, 2 Aug 2023 07:53:57 -0700 From: Jacob Pan To: LKML , iommu@lists.linux.dev, "Lu Baolu" , Joerg Roedel , Jean-Philippe Brucker , "Robin Murphy" Cc: Jason Gunthorpe , "Will Deacon" , "Tian, Kevin" , Yi Liu , "Yu, Fenghua" , Tony Luck , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v11 0/8] Re-enable IDXD kernel workqueue under DMA API Message-ID: <20230802075357.536a8508@jacob-builder> In-Reply-To: <20230724222538.3902553-1-jacob.jun.pan@linux.intel.com> References: <20230724222538.3902553-1-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg/Baolu, Any more comments on this series? Thanks On Mon, 24 Jul 2023 15:25:30 -0700, Jacob Pan wrote: > Hi Joerg and all, > > IDXD kernel work queues were disabled due to the flawed use of kernel VA > and SVA API. > Link: > https://lore.kernel.org/linux-iommu/20210511194726.GP1002214@nvidia.com/ > > The solution is to enable it under DMA API where IDXD shared workqueue > users can use ENQCMDS to submit work on buffers mapped by DMA API. > > This patchset adds support for attaching PASID to the device's default > domain and the ability to allocate global PASIDs from IOMMU APIs. IDXD > driver can then re-enable the kernel work queues and use them under DMA > API. > > This depends on the IOASID removal series. (merged) > https://lore.kernel.org/all/ZCaUBJvUMsJyD7EW@8bytes.org/ > > > Thanks, > > Jacob > > --- > Changelog: > v11: > - Rebased onto Joerg's next tree (v6.5-rc1) > - Split RIDPASID check in invalidation code into patch (6/8) > - Renamed iommu_alloc_global_pasid_dev to > iommu_alloc_global_pasid (2/8) > - Added WARN_ON if no dev_pasid is found during remove (7/8) > v10: > - Fix global PASID alloc function with device's max_pasid=0 > v9: > - Fix an IDXD driver issue where user interrupt enable bit got > cleared during device enable/disable cycle. Reported and tested by > Tony Zhu > - Rebased to v6.4-rc7 > v8: > - further vt-d driver refactoring (3-6) around set/remove device > PASID (Baolu) > - make consistent use of NO_PASID in SMMU code (Jean) > - fix off-by-one error in max PASID check (Kevin) > v7: > - renamed IOMMU_DEF_RID_PASID to be IOMMU_NO_PASID to be more > generic (Jean) > - simplify range checking for sva PASID (Baolu) > v6: > - use a simplified version of vt-d driver change for > set_device_pasid from Baolu. > - check and rename global PASID allocation base > v5: > - exclude two patches related to supervisor mode, taken by VT-d > maintainer Baolu. > - move PASID range check into allocation API so that device > drivers only need to pass in struct device*. (Kevin) > - factor out helper functions in device-domain attach (Baolu) > - make explicit use of RID_PASID across architectures > v4: > - move dummy functions outside ifdef CONFIG_IOMMU_SVA (Baolu) > - dropped domain type check while disabling idxd system PASID > (Baolu) > > v3: > - moved global PASID allocation API from SVA to IOMMU (Kevin) > - remove #ifdef around global PASID reservation during boot > (Baolu) > - remove restriction on PASID 0 allocation (Baolu) > - fix a bug in sysfs domain change when attaching devices > - clear idxd user interrupt enable bit after disabling device( > Fenghua) v2: > - refactored device PASID attach domain ops based on Baolu's > early patch > - addressed TLB flush gap > - explicitly reserve RID_PASID from SVA PASID number space > - get dma domain directly, avoid checking domain types > > > > Jacob Pan (3): > iommu: Generalize PASID 0 for normal DMA w/o PASID > iommu: Move global PASID allocation from SVA to core > dmaengine/idxd: Re-enable kernel workqueue under DMA API > > Lu Baolu (5): > iommu/vt-d: Add domain_flush_pasid_iotlb() > iommu/vt-d: Remove pasid_mutex > iommu/vt-d: Make prq draining code generic > iommu/vt-d: Prepare for set_dev_pasid callback > iommu/vt-d: Add set_dev_pasid callback for dma domain > > drivers/dma/idxd/device.c | 39 ++--- > drivers/dma/idxd/dma.c | 5 +- > drivers/dma/idxd/idxd.h | 9 + > drivers/dma/idxd/init.c | 54 +++++- > drivers/dma/idxd/sysfs.c | 7 - > .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 2 +- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 16 +- > drivers/iommu/intel/iommu.c | 157 +++++++++++++++--- > drivers/iommu/intel/iommu.h | 9 + > drivers/iommu/intel/pasid.c | 2 +- > drivers/iommu/intel/pasid.h | 2 - > drivers/iommu/intel/svm.c | 62 +------ > drivers/iommu/iommu-sva.c | 29 ++-- > drivers/iommu/iommu.c | 28 ++++ > include/linux/iommu.h | 11 ++ > 15 files changed, 287 insertions(+), 145 deletions(-) > Thanks, Jacob