From: Arnd Bergmann <arnd@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v3 7/7] x86: qspinlock-paravirt: fix mising-prototype warning
Date: Thu, 3 Aug 2023 10:26:19 +0200 [thread overview]
Message-ID: <20230803082619.1369127-8-arnd@kernel.org> (raw)
In-Reply-To: <20230803082619.1369127-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
__pv_queued_spin_unlock_slowpath is defined in a header file as a global
function, and designed to be called from an inline asm, but there is
no prototype visible in the definition:
kernel/locking/qspinlock_paravirt.h:493:1: error: no previous prototype for '__pv_queued_spin_unlock_slowpath' [-Werror=missing-prototypes]
Add this to the x86 header that contains the inline asm calling it,
and ensure this gets included before the definition, rather than
after it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v3: split out native_pv_lock_init() changes into a separate patch,
keeping only __pv_queued_spin_unlock_slowpath here
---
arch/x86/include/asm/qspinlock_paravirt.h | 2 ++
kernel/locking/qspinlock_paravirt.h | 20 ++++++++++----------
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/x86/include/asm/qspinlock_paravirt.h b/arch/x86/include/asm/qspinlock_paravirt.h
index 42b17cf10b10e..85b6e3609cb92 100644
--- a/arch/x86/include/asm/qspinlock_paravirt.h
+++ b/arch/x86/include/asm/qspinlock_paravirt.h
@@ -4,6 +4,8 @@
#include <asm/ibt.h>
+void __lockfunc __pv_queued_spin_unlock_slowpath(struct qspinlock *lock, u8 locked);
+
/*
* For x86-64, PV_CALLEE_SAVE_REGS_THUNK() saves and restores 8 64-bit
* registers. For i386, however, only 1 32-bit register needs to be saved
diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h
index 6afc249ce697d..6a0184e9c2348 100644
--- a/kernel/locking/qspinlock_paravirt.h
+++ b/kernel/locking/qspinlock_paravirt.h
@@ -485,6 +485,16 @@ pv_wait_head_or_lock(struct qspinlock *lock, struct mcs_spinlock *node)
return (u32)(atomic_read(&lock->val) | _Q_LOCKED_VAL);
}
+/*
+ * Include the architecture specific callee-save thunk of the
+ * __pv_queued_spin_unlock(). This thunk is put together with
+ * __pv_queued_spin_unlock() to make the callee-save thunk and the real unlock
+ * function close to each other sharing consecutive instruction cachelines.
+ * Alternatively, architecture specific version of __pv_queued_spin_unlock()
+ * can be defined.
+ */
+#include <asm/qspinlock_paravirt.h>
+
/*
* PV versions of the unlock fastpath and slowpath functions to be used
* instead of queued_spin_unlock().
@@ -533,16 +543,6 @@ __pv_queued_spin_unlock_slowpath(struct qspinlock *lock, u8 locked)
pv_kick(node->cpu);
}
-/*
- * Include the architecture specific callee-save thunk of the
- * __pv_queued_spin_unlock(). This thunk is put together with
- * __pv_queued_spin_unlock() to make the callee-save thunk and the real unlock
- * function close to each other sharing consecutive instruction cachelines.
- * Alternatively, architecture specific version of __pv_queued_spin_unlock()
- * can be defined.
- */
-#include <asm/qspinlock_paravirt.h>
-
#ifndef __pv_queued_spin_unlock
__visible __lockfunc void __pv_queued_spin_unlock(struct qspinlock *lock)
{
--
2.39.2
next prev parent reply other threads:[~2023-08-03 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:26 [PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 1/7] x86: Fix amd_check_microcode() declaration Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 2/7] x86: apic: hide unused safe_smp_processor_id on UP Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 3/7] x86: avoid unneeded __div64_32 function definition Arnd Bergmann
2023-08-03 15:59 ` [tip: x86/cleanups] x86/asm: Avoid " tip-bot2 for Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 4/7] x86: purgatory: include header for warn() declaration Arnd Bergmann
2023-08-03 15:59 ` [tip: x86/cleanups] x86/purgatory: Include " tip-bot2 for Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 5/7] x86: alternative: add __alt_reloc_selftest prototype Arnd Bergmann
2023-08-03 15:59 ` [tip: x86/cleanups] x86/alternative: Add a __alt_reloc_selftest() prototype tip-bot2 for Arnd Bergmann
2023-08-03 8:26 ` [PATCH v3 6/7] x86: paravirt: shut up unused native_pv_lock_init() function warning Arnd Bergmann
2023-08-03 15:59 ` [tip: x86/cleanups] x86/paravirt: Silence " tip-bot2 for Arnd Bergmann
2023-08-03 8:26 ` Arnd Bergmann [this message]
2023-08-03 15:59 ` [tip: x86/cleanups] x86/qspinlock-paravirt: Fix missing-prototype warning tip-bot2 for Arnd Bergmann
2023-08-03 10:04 ` [PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803082619.1369127-8-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox