public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Ze Gao <zegao2021@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
	Jiri Olsa <jolsa@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, Ze Gao <zegao@tencent.com>
Subject: Re: [RFC PATCH v6 4/5] sched, tracing: add to report task state in symbolic chars
Date: Thu, 3 Aug 2023 10:59:09 +0200	[thread overview]
Message-ID: <20230803085909.GH212435@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230803083352.1585-5-zegao@tencent.com>

On Thu, Aug 03, 2023 at 04:33:51AM -0400, Ze Gao wrote:
> Internal representations of task state are likely to be changed
> or ordered, and reporting them to userspace without exporting
> them as part of API is basically wrong, which can easily break
> a userspace observability tool as kernel evolves. For example,
> perf suffers from this and still reports wrong states as of this
> writing.
> 
> OTOH, some masqueraded states like TASK_REPORT_IDLE and
> TASK_REPORT_MAX are also reported inadvertently, which confuses
> things even more and most userspace tools do not even take them
> into consideration.
> 
> So add a new variable in company with the old raw value to
> report task state in symbolic chars, which are self-explaining
> and no further translation is needed. Of course this does not
> break any userspace tool.
> 
> Note for PREEMPT_ACTIVE, we introduce 'p' to report it and use
> the old conventions for the rest.
> 
> Signed-off-by: Ze Gao <zegao@tencent.com>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Acked-by: Ian Rogers <irogers@google.com>

I'm not sure you've actually read any of the things I've written. I hate
this. Not going to happen.

  reply	other threads:[~2023-08-03  8:59 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  8:33 [RFC PATCH v6 0/5] fix task state report from sched tracepoint Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 1/5] perf sched: sync state char array with the kernel Ze Gao
2023-08-03  9:09   ` Steven Rostedt
2023-08-03 10:29     ` Ze Gao
2023-08-03 12:25       ` Ze Gao
2023-08-03 12:39     ` Ze Gao
2023-08-03 15:10   ` Steven Rostedt
2023-08-04  2:21     ` Ze Gao
2023-08-04  2:38       ` Ze Gao
2023-08-04  3:19         ` Ze Gao
2023-08-04  3:41           ` Steven Rostedt
2023-08-10  5:50             ` Ze Gao
2023-08-10  6:07               ` [PATCH] perf sched: parse task state from tracepoint print format Ze Gao
2023-08-11 17:28               ` Steven Rostedt
2023-08-14  2:28                 ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 2/5] perf sched: reorganize sched-out task state report code Ze Gao
2023-08-03  9:10   ` Steven Rostedt
2023-08-03 12:37     ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 3/5] sched, tracing: reorganize fields of switch event struct Ze Gao
2023-08-03  8:53   ` Peter Zijlstra
2023-08-03 11:06     ` Ze Gao
2023-08-03  9:18   ` Steven Rostedt
2023-08-03  9:51     ` Peter Zijlstra
2023-08-03 14:45       ` Steven Rostedt
2023-08-03 12:54     ` Ze Gao
2023-08-03 12:57     ` Ze Gao
2023-08-23  2:52   ` kernel test robot
2023-08-03  8:33 ` [RFC PATCH v6 4/5] sched, tracing: add to report task state in symbolic chars Ze Gao
2023-08-03  8:59   ` Peter Zijlstra [this message]
2023-08-03 13:09     ` Ze Gao
2023-08-03  9:29   ` Steven Rostedt
2023-08-03 10:55     ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 5/5] perf sched: prefer to use prev_state_char introduced in sched_switch Ze Gao
2023-08-03  9:34   ` Steven Rostedt
2023-08-03 11:01     ` Ze Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803085909.GH212435@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=zegao2021@gmail.com \
    --cc=zegao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox