From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B715EB64DD for ; Thu, 3 Aug 2023 16:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237325AbjHCQBK (ORCPT ); Thu, 3 Aug 2023 12:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237276AbjHCQBC (ORCPT ); Thu, 3 Aug 2023 12:01:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EED422D for ; Thu, 3 Aug 2023 09:00:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A41A261E0C for ; Thu, 3 Aug 2023 16:00:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84288C433C7; Thu, 3 Aug 2023 16:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691078431; bh=4Kh3ibsHIzFJJq0/G/F3KHIgajbiAH5Vz1Bxyj9o3Vk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aHcukMK9r4SsEvRHz5MB3JYRd9vv2nzO2Dhx15gcmTQYg7K5ElnS+h6qO4o+Aaxxf F1+fKsZxAbCJSNfd+x5YLgUTPwYDzF1cH4b5hoXLYIE/TNhRRfwRPi/JyQzg5oRwIJ 7o5++3UksN4s9nxdAEUcOSnE9d+utZvJgseu3t9NWr0GPI0WhuZurHyN3WpVFDhqmx g/5hKrabvXUQyxOsYA7lPAyTQpOgJMlAeLLkKXBpdo34MDFacaoBpvO1i+VAMooFQG x4T7YYwvvrf6qXmzcbuvVvdLG31a9OUSp1I6kFdI1J6QmrrAJSgEnmzdKiqStNckTL 1mkytn4qKWhEg== Date: Thu, 3 Aug 2023 09:00:29 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: Yunsheng Lin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Larysa Zaremba , Alexander Duyck , Jesper Dangaard Brouer , "Ilias Apalodimas" , Simon Horman , , Subject: Re: [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly Message-ID: <20230803090029.16a6798d@kernel.org> In-Reply-To: <7b77dd3a-fd03-884a-8b8a-f76ab6de5691@intel.com> References: <20230727144336.1646454-1-aleksander.lobakin@intel.com> <20230727144336.1646454-6-aleksander.lobakin@intel.com> <6f8147ec-b8ad-3905-5279-16817ed6f5ae@intel.com> <0fe906a2-5ba1-f24a-efd8-7804ef0683b6@intel.com> <20230802142920.4a777079@kernel.org> <7b77dd3a-fd03-884a-8b8a-f76ab6de5691@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Aug 2023 16:56:22 +0200 Alexander Lobakin wrote: > > FWIW I'm tempted to do something like the patch below (an obvious move, > > I suspect). I want to add another pointer (netdev) to the params and > > Just take napi->dev as I do in libie :) :) The fields have extra semantics, like napi implies that recycling is allowed, and netdev implies that there is only _one_ netdev eating from the PP. There's also a way to get the pp <> netdev from the memory model registration. But I feel like explicit field is cleanest. Anyone, conversation for a later time :) > > I don't want it to eat up bytes in the first cache line. > > The patch is incomplete, we need to stash a one-bit indication in > > the first cache line to know init_callback is not present without > > having to look at @slow. I'll defer doing that cleanly until your > > patches land. > > I would propose to include it in the series, but it has grown a bunch > already and it's better to do that later separately :s Yeah.. I'd be trying to split your series up a little to make progress rather than add more things :( I was going to suggest that you post just the first 3 patches for instance. Should be an easy merge.